852647 - [B2G] [calendar] [system notification] duplicate text in event notification for reminder

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[mdaniloff]

Attachment: event notification extra text is displayed

Repro Steps:

1) Updated to Unagi Build ID: 20130319070203

2) User taps on Calendar icon on homescreen

3) User taps on current day,taps on + (right hand corner)

4) User creates calendar event notification and audio event notification is triggered

 

Expected:

Calendar event notification is grammatically correct and no duplicate text appears

Actual:

Duplicate text appears


Repro frequency:
(2/2, 100%, etc)

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/406b86b4b515
Gaia: c5a8b6476f0dbc456061227a7801e56634683eb0

Comment 1

[Jason Smith [:jsmith]]

Well, that's just plain weird. Kevin - Any ideas?

I'll take a look at this in a little bit.

Comment 2

[Jason Smith [:jsmith]]

Well this doesn't reproduce all of the time in every case. Can you give exact details of the event here to reproduce this?

Comment 3

[mdaniloff]

REVISED STEPS TO REPRODUCE

Repro Steps:

1) Updated to Unagi Build ID: 20130319070203

2) User taps on Calendar icon on homescreen

3) User taps on current day,taps on + (right hand corner)

4) User creates calendar event notification that is 5 minutes ahead of the current time and audio event notification is triggered

 

Expected:

Calendar event notification is grammatically correct and no duplicate text appears

Actual:

Duplicate text appears


Repro frequency:
(2/2, 100%, etc)

Comment 4

[Kevin Grandon :kgrandon]

Date localization content has definitions like:
inMinutes-long[one]   = in a minute
inMinutes-long[two]   = in {{m}} minutes

Calendar localization looks like:
alarm-starting-notice={{title}} starting in {{distance}}

Patch should be pretty simple. I believe we would just need to update the key so it would trigger a translation for all locales for the one key. This would add a late-l10n effort though.

Comment 5

[Jason Smith [:jsmith]]

So if I understand this bug correctly, this is a translation issue - we are duplicate text when we translate, right?

Anyways, if we have incorrect messages in notifications with duplicated text, that's functionally incorrect for the alarms feature. Sounds like a leo nom.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 7

[James Lal [:lightsofapollo]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/47f45bc86420e8ea9693aecd9cb4fddf0e94c5f9

We need l10n review to uplift though.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Since this isn't something being hit every time and we already have an assignee/patch - we'll just track here and once l10n review is passed, please nominate for uplift with risk assessment.

Comment 9

[Jason Smith [:jsmith]]

Kevin - Can you find a l10n reviewer to review this patch?

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 727708 [details]
Github pull request pointer

Who can do a l10n review? Kaze - is that you?

Comment 11

[Fabien Cazenave [:kaze]]

Comment on attachment 727708 [details]
Github pull request pointer

Looks like James merged this patch 12 days ago:
https://github.com/mozilla-b2g/gaia/commit/47f45bc86420e8ea9693aecd9cb4fddf0e94c5f9

Post-mortem r+.

Comment 12

[Jason Smith [:jsmith]]

Comment on attachment 727708 [details]
Github pull request pointer

review+ per kaze's comment above

Comment 14

[Jason Smith [:jsmith]]

Kevin - Can you do the approval process form to get this uplifted?

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 727708 [details]
Github pull request pointer

Would like to uplift this simple text change.

User impact if declined: Poor/confusing UX as text is duplicated.
Testing completed: Manual testing.
Risk to taking this patch (and alternatives if risky): No risk as it's only a text change.

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 727708 [details]
Github pull request pointer

approving low risk patch with l10n review.

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: b730e868940a2fd58d1476032071332a9f78d484