Closed Bug 852676 Opened 7 years ago Closed 7 years ago

Remove unmaintained ETW event support

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: till, Assigned: billm)

Details

Attachments

(1 file)

sfink says the ETW support has been unsupported for quite a while, so it's very probably broken and won't even compile.

Given that it blocks the removal of other cruft, like computedSizeOfThisSlotsElements, we should rip it out.
Assignee: general → wmccloskey
Status: NEW → ASSIGNED
Attachment #727433 - Flags: review?(sphink)
Comment on attachment 727433 [details] [diff] [review]
remove ETW probes

Review of attachment 727433 [details] [diff] [review]:
-----------------------------------------------------------------

I may restore some of this in the future to beef up the set of dtrace probes, but this is fine for now. (And dtrace shouldn't need static probes for everything anyway, since it can just trigger on function entry/exit for things like runtime creation/destruction events.)
Attachment #727433 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/b170e3ee24c0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.