Show manifest URL for packaged apps also

RESOLVED FIXED in 2013-07-18

Status

Marketplace
Reviewer Tools
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: clouserw, Assigned: ngoke)

Tracking

({regression})

2013-07-18
regression
Points:
---

Details

(Whiteboard: p=1)

(Reporter)

Description

5 years ago
If you look at a review detail page (eg. https://marketplace-dev.allizom.org/reviewers/apps/review/jaxspot ) you'll see a "Manifest URL" entry at the top which points to where the manifest is located.

Packaged apps don't have remote hosted manifests but they do have mini-manifests hosted by the marketplace.  When we have a packaged app in the queue, it normally shows no URL there (eg. https://marketplace-dev.allizom.org/reviewers/apps/review/packaged-mozillaball-%E3%82%87-6# ).  Please show the mini-manifest URL there for packaged apps.

This also goes for the result page of app lookups (eg. https://marketplace-dev.allizom.org/lookup/app/412939/summary )

Thanks.
https://marketplace-dev.allizom.org/reviewers/apps/review/packaged-mozillaball-%E3%82%87-6/manifest is 500ing that's why you can't see the mini manifest

IndexError: list index out of range

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "amo/decorators.py", line 33, in wrapper
    return func(request, *args, **kw)
  File "amo/decorators.py", line 65, in wrapper
    return f(request, *args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 131, in wrapper
    response = func(*args, **kw)
  File "mkt/reviewers/views.py", line 569, in app_view_manifest
    manifest = json.loads(_mini_manifest(addon, version.id))
  File "mkt/reviewers/views.py", line 612, in _mini_manifest
    file_ = version.all_files[0]
Keywords: regression
Yeah, under normal circumstances I'm pretty sure we show the url and when clicked you see the packaged app mini-manifest.

In this case this app has 2 versions. The first is still pending and has a file. The 2nd has no file and is named "blocklisted-1.0". Which suggests to me that it was blocklisted but we perhaps failed to create the blocklisted file to attach to that version.

I don't see an indication of blocklisting in the logs, however. I do see a task exception:
Celery TASK exception: OSError: [Errno 2] No such file or directory: '/mnt/netapp_amo_dev/addons-dev.allizom.org/shared_storage/signed_apps/411875/packaged-mozillaball-6-1.0.signed.zip'

Something is bizarre about this. Do we know the steps that got it to this point?
(Reporter)

Comment 3

5 years ago
I don't.  I also just randomly picked that packaged app - I've never seen a manifest URL for a packaged app before.

Don't spin your wheels too much on the example.  This is -dev, anything can happen.  (Plus it's krupa's app)
Here's an example:
https://marketplace-dev.allizom.org/reviewers/apps/review/marble-run-1360148698

It doesn't show the mini-manifest URL but does show the mini-manifest when clicked.
(Reporter)

Comment 5

5 years ago
(In reply to Rob Hudson [:robhudson] from comment #4)
> Here's an example:
> https://marketplace-dev.allizom.org/reviewers/apps/review/marble-run-
> 1360148698
> 
> It doesn't show the mini-manifest URL but does show the mini-manifest when
> clicked.

It should show the URL, and also it's still blank in the lookup tool for that app: https://marketplace-dev.allizom.org/lookup/app/414369/summary
(Assignee)

Updated

5 years ago
Assignee: nobody → ngoke
I'm confused what we're trying to fix here.

The reviewer tools on prod show the actual manifest in the package for packaged apps, which is a lot more useful.  (It used to show the mini-manifest but that got changed during one of the privileged app bugs, iirc).  There isn't a url shown next to the (View) link, but we don't care about the mini-manifest url anyway for review purposes.
(Reporter)

Comment 7

5 years ago
(In reply to Andrew Williamson [:eviljeff] from comment #6)
> I'm confused what we're trying to fix here.
> 
> The reviewer tools on prod show the actual manifest in the package for
> packaged apps, which is a lot more useful.  (It used to show the
> mini-manifest but that got changed during one of the privileged app bugs,
> iirc).  There isn't a url shown next to the (View) link, but we don't care
> about the mini-manifest url anyway for review purposes.

They care about it for partner builds
(In reply to Wil Clouser [:clouserw] from comment #7)
> (In reply to Andrew Williamson [:eviljeff] from comment #6)
> > I'm confused what we're trying to fix here.
> > 
> > The reviewer tools on prod show the actual manifest in the package for
> > packaged apps, which is a lot more useful.  (It used to show the
> > mini-manifest but that got changed during one of the privileged app bugs,
> > iirc).  There isn't a url shown next to the (View) link, but we don't care
> > about the mini-manifest url anyway for review purposes.
> 
> They care about it for partner builds

Oh, this is for the lookup tool. 
I suppose it wouldn't hurt to have it on the review pages as well - as long as the view manifest functionality wasn't affected - but the partners aren't going to use those pages.
(Reporter)

Comment 9

5 years ago
Right.  Review pages aren't this bug, no opinion on that from me.
(Assignee)

Comment 10

5 years ago
https://github.com/mozilla/zamboni/commit/4cf4df9d401b31877f6facbeedf3e6892ee15fd6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-07-18
(In reply to Kevin Ngo [:ngoke] from comment #10)
> https://github.com/mozilla/zamboni/commit/
> 4cf4df9d401b31877f6facbeedf3e6892ee15fd6

Its the URL that's wanted, not the actual manifest.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 12

5 years ago
Okay, added the URL.

https://github.com/mozilla/zamboni/commit/e4750a65e0a38c0f1c681ceb65f8f9f0d6fdc70f
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.