852742 - Remove bogus 'const' from nsViewManager::CreateView()'s "const nsView* aParent" parameter

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

nsViewManager::CreateView() takes a parameter "const nsView* aParent", which it proceeds to const_cast to a nsView*.  So the constness is a bit of a sham there.

Meanwhile, based on a quick sampling of its callers, it seems that it generally gets passed a "nsView*" -- so there doesn't seem to be any need for the parameter to be const.

Filing this bug on making that parameter just a normal "nsView*", assuming I'm not missing any trouble that that'd cause.

Marking dependency on Bug 848218, since this touches the same code that that patch touches, and I think the patch here should land after Bug 848218 so as not to bitrot it.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This builds locally for me, so I think it's valid.

Comment 2

[Daniel Holbert [:dholbert]]

and by Bug 848218 in comment 0, I of course meant bug 852428. (I copypasted the wrong bug number from the top of an attachment page on that bug.)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix (layered on top of bug 852428's patches)

Here's the patch again, bitrot-fixed to layer on top of bug 852428's patches (since I don't intend to land this until after bug 852428 lands).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 726970 [details] [diff] [review]
fix (layered on top of bug 852428's patches)

r=me

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbe9d169f86

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4dbe9d169f86