852765 - Duplicated Facebook icon for each contact after ordering by last name

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Maria Angeles Oteo (:oteo)]

Steps To Reproduce:
1. Go to Settings in Contacts Application
2. Import from FB (your contacts from FB are successfully imported)
3. Enable the "Order by last name" toggle in Contact Settings and press "Done"
4. In the Contact list the contacts imported from FB appear with the FB icon duplicated.

Important:
I am reproducing this bug in V1-train and v1.0.1 branches
I am only be able to reproduce it, the first time the order by last name toggle is activated.

Comment 1

[alberto.pastor]

I can reproduce it. Working on it.

Comment 2

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8730

Pointer to Github pull-request

Comment 3

[Michael Vines [:m1] [:evilmachines]]

(tef+ given there's a (unreviewed) patch for this, and it's a 2 liner)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 727144 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8730

Simple and working perfect!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/f265845ce3a8921fd8f57bf2fff05fd51071b739

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit f265845ce3a8921fd8f57bf2fff05fd51071b739 as:
v1-train: 5c27d322212b6d17c8beab04348d207de6821544
v1.0.1: 5951d9e1e759c6f93283f028be13b849a24702a9

Comment 8

[Mila Davydova]

This issue no longer reproduces on Unagi device.
Build ID: 20130322070203 
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 85fd164691bb852f1cfaf82405df4380629ced6e

When user imports contacts from the Facebook and enables "Order by last name" option, contacts do not get duplicated.
Verified as fixed

Comment 10

[Mila Davydova]

Issue also does not reproduce on the Unagi build 20130326070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia: ace1eb32a313da1232bbdf9cff2581a4b036356d

Verified fixed