Closed Bug 852777 Opened 11 years ago Closed 11 years ago

Make Tilt more extensible


(Firefox Graveyard :: Developer Tools: 3D View, defect, P3)

Windows 8


(Not tracked)

Firefox 23


(Reporter: mossop, Assigned: mossop)




(1 file, 1 obsolete file)

Attached patch WIP patch (obsolete) — Splinter Review
This is a WIP and still fails a few tests but worth feedback at this point.

Basically it adds the contentWindow that Tilt is displaying to the observer notifications sent out (as well as fixing the HIDDEN notification to only get sent when necessary). It also makes the function used to set node positions a property of a presenter. This allows an extension to easily catch an early notification just after the presenter is created and supply its own node function on a per-instance basis. Much nicer than overriding the function in the JSM.

Don't bother with reviewing here, just let me know if the basic concept looks good to you. This builds on top of the patch in bug 852353.
Attachment #726979 - Flags: feedback?(vporof)
Comment on attachment 726979 [details] [diff] [review]
WIP patch

Review of attachment 726979 [details] [diff] [review]:

Looks good at first glance.
Attachment #726979 - Flags: feedback?(vporof) → feedback+
Assignee: nobody → dtownsend+bugmail
Attached patch patch rev 1Splinter Review
Tidied this up and added tests for the notifications and overriding the node callback function. Also been using this with an updated version of my add-on and it works nicely.
Attachment #726979 - Attachment is obsolete: true
Attachment #727938 - Flags: review?(vporof)
Priority: -- → P3
Sorry I'll have to delay reviewing this for a few more days. I'm buried deep into network monitors at this point :)
Comment on attachment 727938 [details] [diff] [review]
patch rev 1

Review of attachment 727938 [details] [diff] [review]:

I'm sorry this took a while. Even worse (better) is that I have nothing bad to say about this patch :) Awesome work, nice and clean. Thanks!
Attachment #727938 - Flags: review?(vporof) → review+
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.