Closed Bug 852813 Opened 11 years ago Closed 7 years ago

AddonManagerInternal should store its listeners in Set objects

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1354186

People

(Reporter: Unfocused, Unassigned)

Details

the various types of listeners stored in AddonManagerInternal (managerListeners, installListeners, addonListeners, and typeListeners) are currently all stores as Arrays. but now days, we have a data structure that is far more appropriate: Set.

See: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Set

So, we should convert these arrays to Set objects, and update all the relevant code in AddonManagerInternal that touches them - which will simplify that code quite a lot.

These arrays are defined here:
https://hg.mozilla.org/mozilla-central/file/126563fd3ba1/toolkit/mozapps/extensions/AddonManager.jsm#l385
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.