Closed
Bug 852843
Opened 12 years ago
Closed 12 years ago
SVGZoomAndPan interface object not being instantiated
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
|
3.99 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #727381 -
Flags: review?(bzbarsky)
|
||
Comment 2•12 years ago
|
||
>+ if ((not descriptor.interface.isCallback() or static) and
>+ not descriptor.interface.isConsequential()):
Why not just:
if descriptor.interface.hasInterfacePrototypeObject() or static:
? Because nothing says a consequential interface can't _also_ be the prototype of something.
That said, if we adjust this part, however we do it, shouldn't we keep the asserts below as they are?
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #727381 -
Attachment is obsolete: true
Attachment #727381 -
Flags: review?(bzbarsky)
Attachment #727511 -
Flags: review?(bzbarsky)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 727511 [details] [diff] [review]
Patch
> # Ignore non-static attributes for callback interfaces
Fix the comment, both places?
r=me
Attachment #727511 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•