Closed Bug 852843 Opened 8 years ago Closed 8 years ago

SVGZoomAndPan interface object not being instantiated

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(1 file, 1 obsolete file)

Patch
3.99 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch Patch (obsolete) — — Splinter Review
Attachment #727381 - Flags: review?(bzbarsky)
>+        if ((not descriptor.interface.isCallback() or static) and
>+            not descriptor.interface.isConsequential()):

Why not just:

  if descriptor.interface.hasInterfacePrototypeObject() or static:

?  Because nothing says a consequential interface can't _also_ be the prototype of something.

That said, if we adjust this part, however we do it, shouldn't we keep the asserts below as they are?
Attached patch Patch — — Splinter Review
Attachment #727381 - Attachment is obsolete: true
Attachment #727381 - Flags: review?(bzbarsky)
Attachment #727511 - Flags: review?(bzbarsky)
Comment on attachment 727511 [details] [diff] [review]
Patch

>         # Ignore non-static attributes for callback interfaces

Fix the comment, both places?

r=me
Attachment #727511 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/c7841e61ba63
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.