Closed Bug 852924 Opened 11 years ago Closed 11 years ago

Follow-up Bug 849186 memory optimizations for Import tasks in v1-train and master

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-, b2g18+ fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
b2g18 + fixed

People

(Reporter: jmcf, Assigned: crdlc)

References

Details

Attachments

(1 file)

Patch v1
188 bytes, text/html
jmcf
: review+
akeybl
: approval-gaia-v1+
Details 
In v1-train and master, consolidate memory-saving optimizations already implemented in v1.0.1 by bug 849186
blocking-b2g: --- → leo?
blocking-b2g: leo? → ---
Summary: Follow-up Bug 849186 memory optimizations for FB Import in v1-train and master → Follow-up Bug 849186 memory optimizations for Import tasks sin v1-train and master
Status: NEW → ASSIGNED
Summary: Follow-up Bug 849186 memory optimizations for Import tasks sin v1-train and master → Follow-up Bug 849186 memory optimizations for Import tasks in v1-train and master
Assignee: jmcf → crdlc
Attached file Patch v1 — 

        Attachment #727677 -
        Flags: review?(jmcf)

    
  
blocking-b2g: --- → leo?

    
  

        Attachment #727677 -
        Flags: review?(jmcf) → review+

    
  

        Attachment #727677 -
        Attachment mime type: text/plain → text/html

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/d2a68bc3c26312bbd70c926aedbdef0fc972805e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
This broke the unit tests : https://travis-ci.org/mozilla-b2g/gaia/builds/5804556

Is it possible to have a fast follow up to fix this please ?
Flags: needinfo?(crdlc)

    
    

    
  
yes, in a couple of hours
Flags: needinfo?(crdlc)

    
  
Blocks: 854840

    
    

    
  
done Julien, thanks

    
    

    
  
Please request approval for v1.1 on the patch with a risk evaluation. We don't have any new memory requirements in v1.1, so this wouldn't be a blocker.
blocking-b2g: leo? → -

          tracking-b2g18:
          --- → +

    
    

    
  
Comment on attachment 727677 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Follow-up of bug 849186 memory optimizations that arose during the Buri certification. 
User impact if declined: High, we can face the same issues during leo certification 
Testing completed: Yes 
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: https://github.com/mozilla-b2g/gaia/commit/d2a68bc3c26312bbd70c926aedbdef0fc972805e

        Attachment #727677 -
        Flags: approval-gaia-v1?(francisco.jordano)

    
  

        Attachment #727677 -
        Flags: approval-gaia-v1?(francisco.jordano) → approval-gaia-v1?

    
  

        Attachment #727677 -
        Flags: approval-gaia-v1? → approval-gaia-v1+

    
    

    
  
Uplifted commit d2a68bc3c26312bbd70c926aedbdef0fc972805e as:
v1-train: b7227ce67b31354217beb0ee5a2101b6430c7370

          status-b2g18:
          --- → fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: