852950 - Kill xpcom.dll/libxpcom.so/xpcom.dylib

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use signature sniffing for Elf and Mach-O binaries for dependentlibs.py

Comment 2

[Mike Hommey [:glandium]]

Attachment: Kill libxpcom

Comment 3

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #2)
> Created attachment 727184 [details] [diff] [review]
> Kill libxpcom

Note there's more we can clean up in the xpcom standalone glue, but i figured this could be done in a followup because we may want to change the standalone glue API at the same time.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 727184 [details] [diff] [review]
Kill libxpcom

There's something fishy going on with debug builds.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Kill libxpcom

try: -b do -p all -u all -t none

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Created attachment 727244 [details] [diff] [review]
> Kill libxpcom
> 
> try: -b do -p all -u all -t none

https://tbpl.mozilla.org/?tree=Try&rev=86c717dafc7b

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1da324d86a59
https://hg.mozilla.org/integration/mozilla-inbound/rev/f12e5c87adf6

Comment 8

[Daniel Holbert [:dholbert]]

In my local m-i debug build after this landed, I'm getting this error on startup:
>    XPCOMGlueLoad error for file /scratch/work/builds/mozilla-inbound/obj/dist/bin/libxul.so:
>    libmozsqlite3.so: cannot open shared object file: No such file or directory
>    Couldn't load XPCOM.

(I clobbered, for good measure; that didn't fix the issue.)

I suspect it's fallout from this bug; not 100% sure though.

Comment 9

[Mike Hommey [:glandium]]

Backed out the kill part, because it breaks running from dist/bin.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3c7024506b

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1da324d86a59

Comment 11

[Mike Hommey [:glandium]]

Attachment: Kill libxpcom part 2

I ended up refactoring the entire standalone glue, because I was sick of having to change every implementation one by one (which has been the case about every time I had to change anything in that directory)

This applies on top of the previous patch, and will be folded when (re)landing.

Comment 12

[Mike Hommey [:glandium]]

Attachment: Kill libxpcom part 2

An update to fix windows/os2 (forgot to re-add ns_strrpbrk) ; also replaced NULL with nullptr while I was there.

Comment 13

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20454bf62bb1

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20454bf62bb1

Comment 15

[Nickolay_Ponomarev]

Could someone please update https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Glue ?