Closed
Bug 852950
Opened 11 years ago
Closed 11 years ago
Kill xpcom.dll/libxpcom.so/xpcom.dylib
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Keywords: dev-doc-needed)
Attachments
(3 files, 2 obsolete files)
5.46 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
86.02 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
40.38 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #727179 -
Flags: review?(ted)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #727184 -
Flags: review?(benjamin)
Updated•11 years ago
|
Attachment #727179 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2) > Created attachment 727184 [details] [diff] [review] > Kill libxpcom Note there's more we can clean up in the xpcom standalone glue, but i figured this could be done in a followup because we may want to change the standalone glue API at the same time.
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 727184 [details] [diff] [review] Kill libxpcom There's something fishy going on with debug builds.
Attachment #727184 -
Flags: review?(benjamin)
Assignee | ||
Comment 5•11 years ago
|
||
try: -b do -p all -u all -t none
Attachment #727244 -
Flags: review?(benjamin)
Assignee | ||
Updated•11 years ago
|
Attachment #727184 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #5) > Created attachment 727244 [details] [diff] [review] > Kill libxpcom > > try: -b do -p all -u all -t none https://tbpl.mozilla.org/?tree=Try&rev=86c717dafc7b
Updated•11 years ago
|
Attachment #727244 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1da324d86a59 https://hg.mozilla.org/integration/mozilla-inbound/rev/f12e5c87adf6
Comment 8•11 years ago
|
||
In my local m-i debug build after this landed, I'm getting this error on startup:
> XPCOMGlueLoad error for file /scratch/work/builds/mozilla-inbound/obj/dist/bin/libxul.so:
> libmozsqlite3.so: cannot open shared object file: No such file or directory
> Couldn't load XPCOM.
(I clobbered, for good measure; that didn't fix the issue.)
I suspect it's fallout from this bug; not 100% sure though.
Assignee | ||
Comment 9•11 years ago
|
||
Backed out the kill part, because it breaks running from dist/bin. https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3c7024506b
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1da324d86a59
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•11 years ago
|
||
I ended up refactoring the entire standalone glue, because I was sick of having to change every implementation one by one (which has been the case about every time I had to change anything in that directory) This applies on top of the previous patch, and will be folded when (re)landing.
Attachment #728152 -
Flags: review?(benjamin)
Assignee | ||
Comment 12•11 years ago
|
||
An update to fix windows/os2 (forgot to re-add ns_strrpbrk) ; also replaced NULL with nullptr while I was there.
Attachment #728264 -
Flags: review?(benjamin)
Assignee | ||
Updated•11 years ago
|
Attachment #728152 -
Attachment is obsolete: true
Attachment #728152 -
Flags: review?(benjamin)
Updated•11 years ago
|
Attachment #728264 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/20454bf62bb1
Comment 14•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20454bf62bb1
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Comment 15•10 years ago
|
||
Could someone please update https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Glue ?
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•