Closed Bug 852950 Opened 7 years ago Closed 7 years ago

Kill xpcom.dll/libxpcom.so/xpcom.dylib

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: glandium, Assigned: glandium)

References

(Depends on 2 open bugs)

Details

(Keywords: dev-doc-needed)

Attachments

(3 files, 2 obsolete files)

No description provided.
Assignee: nobody → mh+mozilla
Attached patch Kill libxpcom (obsolete) — Splinter Review
Attachment #727184 - Flags: review?(benjamin)
Attachment #727179 - Flags: review?(ted) → review+
(In reply to Mike Hommey [:glandium] from comment #2)
> Created attachment 727184 [details] [diff] [review]
> Kill libxpcom

Note there's more we can clean up in the xpcom standalone glue, but i figured this could be done in a followup because we may want to change the standalone glue API at the same time.
Comment on attachment 727184 [details] [diff] [review]
Kill libxpcom

There's something fishy going on with debug builds.
Attachment #727184 - Flags: review?(benjamin)
Attached patch Kill libxpcomSplinter Review
try: -b do -p all -u all -t none
Attachment #727244 - Flags: review?(benjamin)
Attachment #727184 - Attachment is obsolete: true
(In reply to Mike Hommey [:glandium] from comment #5)
> Created attachment 727244 [details] [diff] [review]
> Kill libxpcom
> 
> try: -b do -p all -u all -t none

https://tbpl.mozilla.org/?tree=Try&rev=86c717dafc7b
Attachment #727244 - Flags: review?(benjamin) → review+
In my local m-i debug build after this landed, I'm getting this error on startup:
>    XPCOMGlueLoad error for file /scratch/work/builds/mozilla-inbound/obj/dist/bin/libxul.so:
>    libmozsqlite3.so: cannot open shared object file: No such file or directory
>    Couldn't load XPCOM.

(I clobbered, for good measure; that didn't fix the issue.)

I suspect it's fallout from this bug; not 100% sure though.
Backed out the kill part, because it breaks running from dist/bin.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3c7024506b
https://hg.mozilla.org/mozilla-central/rev/1da324d86a59
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Kill libxpcom part 2 (obsolete) — Splinter Review
I ended up refactoring the entire standalone glue, because I was sick of having to change every implementation one by one (which has been the case about every time I had to change anything in that directory)

This applies on top of the previous patch, and will be folded when (re)landing.
Attachment #728152 - Flags: review?(benjamin)
An update to fix windows/os2 (forgot to re-add ns_strrpbrk) ; also replaced NULL with nullptr while I was there.
Attachment #728264 - Flags: review?(benjamin)
Attachment #728152 - Attachment is obsolete: true
Attachment #728152 - Flags: review?(benjamin)
Attachment #728264 - Flags: review?(benjamin) → review+
Blocks: 855078
https://hg.mozilla.org/mozilla-central/rev/20454bf62bb1
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Depends on: 855881
Depends on: 856291
Depends on: 857147
Blocks: 844288
Depends on: 893671
You need to log in before you can comment on or make changes to this bug.