Closed
Bug 853067
Opened 11 years ago
Closed 11 years ago
Disable parallelarray in beta/release/esr for now
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: nmatsakis, Unassigned)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
54.35 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Right now ParallelArray is always on, but there should be a preference to enable/disable it.
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #727322 -
Flags: review?(sphink)
Comment 2•11 years ago
|
||
Comment on attachment 727322 [details] [diff] [review] Disable ParallelArray for beta, release, and esr Review of attachment 727322 [details] [diff] [review]: ----------------------------------------------------------------- r+ if you change all |if (parallelEnabled)| to |if ('parallel-arrays' in getBuildConfiguration())| (or whatever name you prefer in place of 'parallel-arrays'.) ::: js/src/builtin/TestingFunctions.cpp @@ +914,5 @@ > + JS_SET_RVAL(cx, vp, JSVAL_FALSE); > +#endif > + return true; > +} > + Can you put this in GetBuildConfiguration instead?
Attachment #727322 -
Flags: review?(sphink) → review+
Reporter | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cf42a8e6e5
Reporter | ||
Updated•11 years ago
|
Summary: Add a preference to enable/disable parallelarray → Disable parallelarray in beta/release/esr for now
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/44cf42a8e6e5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Comment 5•11 years ago
|
||
I've added this bug to the compatibility doc. Please correct the info if wrong. https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22 Also, please update the following docs: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/ParallelArray
Keywords: dev-doc-needed
Comment 6•11 years ago
|
||
(In reply to Kohei Yoshino from comment #5) > Also, please update the following docs: > https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/ > ParallelArray Added a note.
Updated•11 years ago
|
Keywords: site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•