Last Comment Bug 853067 - Disable parallelarray in beta/release/esr for now
: Disable parallelarray in beta/release/esr for now
Status: RESOLVED FIXED
: dev-doc-complete, site-compat
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: 22 Branch
: All All
: -- normal (vote)
: mozilla22
Assigned To: general
:
Mentors:
Depends on: 861705
Blocks: 853065 867019
  Show dependency treegraph
 
Reported: 2013-03-20 11:34 PDT by Niko Matsakis [:nmatsakis]
Modified: 2013-06-21 00:25 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Disable ParallelArray for beta, release, and esr (54.35 KB, patch)
2013-03-20 12:45 PDT, Niko Matsakis [:nmatsakis]
sphink: review+
Details | Diff | Splinter Review

Description Niko Matsakis [:nmatsakis] 2013-03-20 11:34:05 PDT
Right now ParallelArray is always on, but there should be a preference to enable/disable it.
Comment 1 Niko Matsakis [:nmatsakis] 2013-03-20 12:45:22 PDT
Created attachment 727322 [details] [diff] [review]
Disable ParallelArray for beta, release, and esr
Comment 2 Steve Fink [:sfink] [:s:] 2013-03-20 13:29:17 PDT
Comment on attachment 727322 [details] [diff] [review]
Disable ParallelArray for beta, release, and esr

Review of attachment 727322 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you change all |if (parallelEnabled)| to |if ('parallel-arrays' in getBuildConfiguration())| (or whatever name you prefer in place of 'parallel-arrays'.)

::: js/src/builtin/TestingFunctions.cpp
@@ +914,5 @@
> +    JS_SET_RVAL(cx, vp, JSVAL_FALSE);
> +#endif
> +    return true;
> +}
> +

Can you put this in GetBuildConfiguration instead?
Comment 3 Niko Matsakis [:nmatsakis] 2013-03-25 10:05:58 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cf42a8e6e5
Comment 4 Phil Ringnalda (:philor) 2013-03-25 21:46:42 PDT
https://hg.mozilla.org/mozilla-central/rev/44cf42a8e6e5
Comment 5 Kohei Yoshino [:kohei] 2013-03-29 10:20:22 PDT
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22

Also, please update the following docs:
https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/ParallelArray
Comment 6 Kohei Yoshino [:kohei] 2013-03-29 11:09:11 PDT
(In reply to Kohei Yoshino from comment #5)
> Also, please update the following docs:
> https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/
> ParallelArray

Added a note.

Note You need to log in before you can comment on or make changes to this bug.