Disable parallelarray in beta/release/esr for now

RESOLVED FIXED in mozilla22

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nmatsakis, Unassigned)

Tracking

({dev-doc-complete, site-compat})

22 Branch
mozilla22
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Right now ParallelArray is always on, but there should be a preference to enable/disable it.
(Reporter)

Updated

4 years ago
Blocks: 853065
(Reporter)

Comment 1

4 years ago
Created attachment 727322 [details] [diff] [review]
Disable ParallelArray for beta, release, and esr
Attachment #727322 - Flags: review?(sphink)
Comment on attachment 727322 [details] [diff] [review]
Disable ParallelArray for beta, release, and esr

Review of attachment 727322 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you change all |if (parallelEnabled)| to |if ('parallel-arrays' in getBuildConfiguration())| (or whatever name you prefer in place of 'parallel-arrays'.)

::: js/src/builtin/TestingFunctions.cpp
@@ +914,5 @@
> +    JS_SET_RVAL(cx, vp, JSVAL_FALSE);
> +#endif
> +    return true;
> +}
> +

Can you put this in GetBuildConfiguration instead?
Attachment #727322 - Flags: review?(sphink) → review+
(Reporter)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/44cf42a8e6e5
(Reporter)

Updated

4 years ago
Summary: Add a preference to enable/disable parallelarray → Disable parallelarray in beta/release/esr for now
https://hg.mozilla.org/mozilla-central/rev/44cf42a8e6e5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22

Also, please update the following docs:
https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/ParallelArray
Keywords: dev-doc-needed
(In reply to Kohei Yoshino from comment #5)
> Also, please update the following docs:
> https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/
> ParallelArray

Added a note.
Keywords: dev-doc-needed → dev-doc-complete
OS: Mac OS X → All
Hardware: x86 → All
Depends on: 861705
(Reporter)

Updated

4 years ago
Blocks: 867019

Updated

4 years ago
Keywords: site-compat
You need to log in before you can comment on or make changes to this bug.