Closed Bug 853077 Opened 7 years ago Closed 7 years ago

Don't queue empty buffers in the opensles cubeb backend

Categories

(Core :: Audio/Video, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: mwu, Assigned: mwu)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Don't queue empty buffers (obsolete) — Splinter Review
I discovered this while debugging bug 852821. It might fix bug 852821, but even if it doesn't, it seems like the right thing to do.
Attachment #727295 - Flags: review?(kinetik)
Comment on attachment 727295 [details] [diff] [review]
Don't queue empty buffers

Review of attachment 727295 [details] [diff] [review]:
-----------------------------------------------------------------

Not queuing empty buffers makes sense.

I don't think we want to call drain immediately though, since we need to wait for any enqueued buffers to be returned first.  Can we rely on the existing logic in bufferqueue_callback?
This version only drains immediately if we didn't queue any buffers at all.
Attachment #727295 - Attachment is obsolete: true
Attachment #727295 - Flags: review?(kinetik)
Attachment #727378 - Flags: review?(kinetik)
Attachment #727378 - Flags: review?(kinetik) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3446228af9dc

This also included a fix to update.sh to make it work on OSX.
https://hg.mozilla.org/mozilla-central/rev/3446228af9dc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.