Closed
Bug 853077
Opened 13 years ago
Closed 13 years ago
Don't queue empty buffers in the opensles cubeb backend
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file, 1 obsolete file)
|
788 bytes,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
I discovered this while debugging bug 852821. It might fix bug 852821, but even if it doesn't, it seems like the right thing to do.
Attachment #727295 -
Flags: review?(kinetik)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 727295 [details] [diff] [review]
Don't queue empty buffers
Review of attachment 727295 [details] [diff] [review]:
-----------------------------------------------------------------
Not queuing empty buffers makes sense.
I don't think we want to call drain immediately though, since we need to wait for any enqueued buffers to be returned first. Can we rely on the existing logic in bufferqueue_callback?
|
Assignee | |
Comment 2•13 years ago
|
||
This version only drains immediately if we didn't queue any buffers at all.
Attachment #727295 -
Attachment is obsolete: true
Attachment #727295 -
Flags: review?(kinetik)
Attachment #727378 -
Flags: review?(kinetik)
|
|
||
Updated•13 years ago
|
Attachment #727378 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3446228af9dc
This also included a fix to update.sh to make it work on OSX.
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•