853083 - Pinned tabs have too much left margin

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot of the problem

See screenshot (UX build on the top, shorlander spec[1] on the bottom). I'm not sure if this affects the other platforms.

[1]: http://people.mozilla.com/~shorlander/files/australis-design-specs/images/Australis-i01-DesignSpec-MainWindow-%28AppTab%29.jpg

Comment 1

[u428464]

In fact I see this issue with "classic" tabs as well.

Comment 2

[:Gijs (he/him)]

I wanted to take a look at this, but it looks like we're currently pushing tabs out by the size of the app button... is this just going to be fixed when we've gotten rid of the app button? (bug 863753)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

The screenshot I put in here was with the app button collapsed, so I think this will still be an issue after bug 863753 is closed.

Comment 4

[:Gijs (he/him)]

Attachment: Patch

Probably sensible to hold off on review for this until we've actually gotten rid of the app button, but this works.

Comment 5

[:Gijs (he/him)]

Attachment: Screenshot with adjusted padding

Comment 6

[u428464]

I can confirm it's a problem with both pinned and normal tabs.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 744130 [details] [diff] [review]
Patch

Review of attachment 744130 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me. Thanks Gijs!

Comment 8

[:Gijs (he/him)]

http://hg.mozilla.org/projects/ux/rev/00787d1b557a

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/00787d1b557a

Comment 10

[ganesh_sahai1]

Tested on :---
User Agent : Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0
Version : Firefox  28.0a1
Platform Tested : x86_64, Win 8

Status : Found Fixed

Comment 11

[u279076]

Marking this verified fixed based on comment 10. Thanks for your help Ganesh.