During the re-implementation of contentStyle using the new DOMWindowUtils method, sometimes `contentScript` wasn't executed: that was because an exception was raised but swallowed by `registry` module, that page-mod uses. I suspect more We should avoid to swallows exceptions in this way, and possibly deprecate `registry` module too.
"I suspect more" -> "I suspect more errors could be currently swallowed in the same way, even in our tests".
Created attachment 8517155 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1696 The registry module isn't used anylonger.
Attachment #8517155 - Flags: review?(rFobic)
Attachment #8517155 - Flags: review?(rFobic) → review+
Assignee: zer0 → evold
OS: Mac OS X → All
Hardware: x86 → All
Summary: The registry module is swallowing errors → Remove the unused registry module
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/5d53bddb4fd2ae1bffa48e2e65968e56eeef6ebc Bug 853085 Remove the unused registry module r=gozala
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.