Remove the unused registry module

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: zer0, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
During the re-implementation of contentStyle using the new DOMWindowUtils method, sometimes `contentScript` wasn't executed: that was because an exception was raised but swallowed by `registry` module, that page-mod uses.
I suspect more 

We should avoid to swallows exceptions in this way, and possibly deprecate `registry` module too.
(Reporter)

Comment 1

5 years ago
"I suspect more" -> "I suspect more errors could be currently swallowed in the same way, even in our tests".

Updated

5 years ago
Priority: -- → P1
(Reporter)

Updated

4 years ago
Assignee: nobody → zer0
Created attachment 8517155 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1696

The registry module isn't used anylonger.
Attachment #8517155 - Flags: review?(rFobic)
Attachment #8517155 - Flags: review?(rFobic) → review+
Assignee: zer0 → evold
OS: Mac OS X → All
Hardware: x86 → All
Summary: The registry module is swallowing errors → Remove the unused registry module
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Blocks: 1114752
You need to log in before you can comment on or make changes to this bug.