Closed
Bug 853125
Opened 12 years ago
Closed 12 years ago
Editing an event with no alarm reminders always shows the default alarm reminders, not the fact that there are no reminders
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified)
People
(Reporter: jsmith, Assigned: mikehenrty)
Details
(Whiteboard: c=calendar p=8 leorun1, inarirun2)
Attachments
(1 file)
Build: B2G 18 3/19/2013
Device: Unagi
Steps:
1. Create an event with no alarm reminders
2. Edit that event
Expected:
The remind me field should say none.
Actual:
The remind me field indicates the default alarm reminder time. This is incorrect behavior - there was no alarm set for this event.
Reporter | ||
Comment 1•12 years ago
|
||
leo nom - clearly incorrect behavior and a simple use case. Probably should block.
blocking-b2g: --- → leo?
Comment 2•12 years ago
|
||
So are we only supposed to pre-populate the default alarms on create event, and not edit?
Comment 3•12 years ago
|
||
Makes sense to me.... if we are editing the user (or server) has specified the defaults and we should let them do whatever they want.
Comment 4•12 years ago
|
||
Our partners feel this is a leo+ bug.
Assignee: nobody → jlal
blocking-b2g: leo? → leo+
Comment 5•12 years ago
|
||
This reproduces on the Leo device.
Build ID: 20130411070205
Environmental Variables:
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66
UCID: calendar-051
Whiteboard: leorun1
Updated•12 years ago
|
Assignee: jlal → nobody
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mhenretty
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #742621 -
Flags: review?(kgrandon)
Updated•12 years ago
|
Status: NEW → ASSIGNED
Whiteboard: leorun1 → c=calendar leorun1
Comment 7•12 years ago
|
||
Added c= and p= whiteboard tags to get this into the scrumbugs backlog.
Whiteboard: c=calendar leorun1 → c=calendar p=8 leorun1
Assignee | ||
Comment 8•12 years ago
|
||
James, I updated the pull request per your feedback. Please review at your leisure.
Flags: needinfo?(jlal)
Comment 9•12 years ago
|
||
Comment on attachment 742621 [details] [review]
Pull Request
Hey Mike, looks good! I'd really like to see a unit test if possible. Could we add a test case to: modify_event_test.js?
Attachment #742621 -
Flags: review?(kgrandon)
Assignee | ||
Comment 10•12 years ago
|
||
Ok Kevin, I added a test case for this. On Gareth's suggestion, I also checked out the old version of modify_event.js and made sure the new test failed against it. Let me know if you want me to add anything else.
Flags: needinfo?(kgrandon)
Comment 11•12 years ago
|
||
I left one small comment ( mostly commenting to clear the needinfo )
Flags: needinfo?(jlal)
Comment 12•12 years ago
|
||
Comment on attachment 742621 [details] [review]
Pull Request
Looks good. Please squash the commits using rebase then we can land this.
Attachment #742621 -
Flags: review+
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 13•12 years ago
|
||
Commits squashed. Updating the PR based on :lightsofallo's comments.
Flags: needinfo?(jlal)
Comment 15•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 16•12 years ago
|
||
Uplifted a7690eb906ccab88fb806ca9ba3ef67b97331154 to:
v1-train: bc5647d49f91e78e4ef14d91e4635dca374f1fb4
status-b2g18:
--- → fixed
Reporter | ||
Comment 17•12 years ago
|
||
Verified on a 5/20 build with some sanity tests with and without alarm reminders on offline events.
Keywords: verifyme
Updated•12 years ago
|
Whiteboard: c=calendar p=8 leorun1 → c=calendar p=8 leorun1, inarirun2
Reporter | ||
Updated•12 years ago
|
Flags: in-moztrap?
Updated•12 years ago
|
Flags: in-moztrap? → in-moztrap?(cschmoeckel)
Comment 18•12 years ago
|
||
Added Calendar Suite Test Case #8908 - Test that editing an event with no alarm reminders shows that no alarm reminders are set.
Flags: in-moztrap?(cschmoeckel) → in-moztrap+
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•