Closed Bug 853125 Opened 12 years ago Closed 12 years ago

Editing an event with no alarm reminders always shows the default alarm reminders, not the fact that there are no reminders

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 verified)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- verified

People

(Reporter: jsmith, Assigned: mikehenrty)

Details

(Whiteboard: c=calendar p=8 leorun1, inarirun2)

Attachments

(1 file)

Build: B2G 18 3/19/2013 Device: Unagi Steps: 1. Create an event with no alarm reminders 2. Edit that event Expected: The remind me field should say none. Actual: The remind me field indicates the default alarm reminder time. This is incorrect behavior - there was no alarm set for this event.
leo nom - clearly incorrect behavior and a simple use case. Probably should block.
blocking-b2g: --- → leo?
So are we only supposed to pre-populate the default alarms on create event, and not edit?
Makes sense to me.... if we are editing the user (or server) has specified the defaults and we should let them do whatever they want.
Our partners feel this is a leo+ bug.
Assignee: nobody → jlal
blocking-b2g: leo? → leo+
This reproduces on the Leo device. Build ID: 20130411070205 Environmental Variables: Kernel Date: Mar 15 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473 Gaia: e7e338a765e22334b40ced41489a785941382c66 UCID: calendar-051
Whiteboard: leorun1
Assignee: jlal → nobody
Assignee: nobody → mhenretty
Attached file Pull Request
Attachment #742621 - Flags: review?(kgrandon)
Status: NEW → ASSIGNED
Whiteboard: leorun1 → c=calendar leorun1
Added c= and p= whiteboard tags to get this into the scrumbugs backlog.
Whiteboard: c=calendar leorun1 → c=calendar p=8 leorun1
James, I updated the pull request per your feedback. Please review at your leisure.
Flags: needinfo?(jlal)
Comment on attachment 742621 [details] [review] Pull Request Hey Mike, looks good! I'd really like to see a unit test if possible. Could we add a test case to: modify_event_test.js?
Attachment #742621 - Flags: review?(kgrandon)
Ok Kevin, I added a test case for this. On Gareth's suggestion, I also checked out the old version of modify_event.js and made sure the new test failed against it. Let me know if you want me to add anything else.
Flags: needinfo?(kgrandon)
I left one small comment ( mostly commenting to clear the needinfo )
Flags: needinfo?(jlal)
Comment on attachment 742621 [details] [review] Pull Request Looks good. Please squash the commits using rebase then we can land this.
Attachment #742621 - Flags: review+
Flags: needinfo?(kgrandon)
Commits squashed. Updating the PR based on :lightsofallo's comments.
Flags: needinfo?(jlal)
LGTM
Flags: needinfo?(jlal)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Keywords: verifyme
QA Contact: jsmith
Uplifted a7690eb906ccab88fb806ca9ba3ef67b97331154 to: v1-train: bc5647d49f91e78e4ef14d91e4635dca374f1fb4
Verified on a 5/20 build with some sanity tests with and without alarm reminders on offline events.
Whiteboard: c=calendar p=8 leorun1 → c=calendar p=8 leorun1, inarirun2
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap?(cschmoeckel)
Added Calendar Suite Test Case #8908 - Test that editing an event with no alarm reminders shows that no alarm reminders are set.
Flags: in-moztrap?(cschmoeckel) → in-moztrap+
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: