853136 - Prepare some tests for HTMLDocument using a WebIDL binding

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 727341 [details] [diff] [review]
v1

Review of attachment 727341 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/test/browser_webconsole_bug_651501_document_body_autocomplete.js
@@ +122,5 @@
>  
>    // NB: We pull the properties off the prototype, rather than off object itself,
>    // so that expandos like |constructor|, which the propPanel can't see, are not
>    // included.
> +  for (let prop in Object.getPrototypeOf(content.document).wrappedObject) {

So this is because we'll now have meaningful Xrays to the prototype, right?

::: js/xpconnect/tests/mochitest/file_bug650273.html
@@ +10,5 @@
>                  l();
>                  return "a";
>          };
> +        var f = Object.getOwnPropertyDescriptor(Document.prototype, "title").set;
> +        setTimeout(f.bind(document), 0, o);

Hm, this almost certainly isn't taking the old codepath that was taken with lookupMethod. But lookupMethod has already been reimplemented since this test was written, so I don't think there's much point in worrying about it.

Comment 2

[Peter Van der Beken [:peterv]]

(In reply to Bobby Holley (:bholley) from comment #1)
> > +  for (let prop in Object.getPrototypeOf(content.document).wrappedObject) {
> 
> So this is because we'll now have meaningful Xrays to the prototype, right?

Yes, exactly.

Comment 3

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62a4aa80d668

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/62a4aa80d668