853177 - promote Promise.js to toolkit

Status: RESOLVED WONTFIX

(Toolkit :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Given that the Promise module is starting to be used everywhere in the toolkit, is it still meaningful to get it from addon-sdk?

Comment 1

[Dave Townsend [:mossop]]

(In reply to David Rajchenbach Teller [:Yoric] <on workweek, will not follow bugzilla until March 26th> from comment #0)
> Given that the Promise module is starting to be used everywhere in the
> toolkit, is it still meaningful to get it from addon-sdk?

Sure, why not?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Architecturally, having core components (i.e. most of toolkit/) depend on extensibility components (addon-sdk/) is a little surprising. The fact that these extensibility components are based outside of mozilla-central makes things a little harder to manage.

However, the "real" solution might be on bug 810490 and the companion etherpad-based conversation.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to David Rajchenbach Teller [:Yoric] from comment #2)
> Architecturally, having core components (i.e. most of toolkit/) depend on
> extensibility components (addon-sdk/) is a little surprising.

"addon-sdk" may not be the best name given its intended purpose. I think it should generally be considered it a "core component". The ownership structures are different, of course, which seems to be the core issue here. If moving the code reduces friction to making required changes to it, I'm all for it.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Mossop succeeded at convincing me that this probably won't be needed.