853200 - [b2g-bluetooth] Remove unused event handlers from idl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

We have a great number of event handlers in nsIDOMBluetoothAdpater.idl, however, some of them aren't used now. I think it's time to remove them and make our idl clearer.

For example, onpropertychanged in nsIDOMBluetoothManager.idl, nsIDOMBluetoothAdpater.idl, and nsIDOMBluetoothDevice.idl.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Remove unused event handlers from idl

The following events are removed from Bluetooth-related idl:

For nsIDOMBluetoothAdapter.idl
- ondevicedisappeared: unused
- ondevicecreated: unused
- onpropertychanged: unused
- onrequestconfirmation: replaced by system message
- onrequestpasskey: replaced by system message
- onrequestpincode: replaced by system message
- onauthorize: replaced by system message
- oncancel: replaced by system message

For nsIDOMBluetoothDevice.idl
- onpropertychanged: unused
- onconnected: unused
- ondisconnected: unused




Besides, attribute "enabled" is also removed from Adapter since no property named Enabled in Bluez and mEnabled has never been set.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 728883 [details] [diff] [review]
Patch 1(v1): Remove unused event handlers from idl

Review of attachment 728883 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, these changes won't affect Bluetooth logic. Please ask a DOM API peer for another review since the interface is changed.

::: dom/bluetooth/BluetoothAdapter.h
@@ +68,2 @@
>                        nsIDOMDOMRequest** aRequest);
>    

nit: extra whitespaces

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

try: 

https://tbpl.mozilla.org/?tree=Try&rev=32356b174ba3
https://tbpl.mozilla.org/?tree=Try&rev=4315873a43b4

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

https://tbpl.mozilla.org/?tree=Try&rev=4315873a43b4

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e503b1458e77

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e503b1458e77