xpcom/glue/standalone/nsGlueLinkingDlopen.cpp:12:0: warning: "_GNU_SOURCE" redefined

RESOLVED WORKSFORME

Status

defect
RESOLVED WORKSFORME
7 years ago
2 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

(Blocks 1 bug)

Trunk
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

I've been getting this build warning for a while, but haven't filed it yet:
{
 xpcom/glue/standalone/nsGlueLinkingDlopen.cpp:12:0: warning: "_GNU_SOURCE" redefined [enabled by default]
   #define _GNU_SOURCE
   ^
 <command-line>:0:0: note: this is the location of the previous definition
}

Looks like this #define was added in bug 632404.  Not sure exactly what's #defining it on the command-line (looks like it could be a few things; from a quick MXR search, there are several makefiles and configure files that define it).

I suspect we want to wrap this #define with a #ifndef, like we do in e.g. nsStackWalk.cpp:
 https://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsStackWalk.cpp#1205
Bug 852950 removed nsGlueLinkingDlopen.cpp.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.