853236 - Provide access to Google CalDAV v2 API

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Google is shutting down their v1 API, we need to move to the new one that uses OAuth. This means we need to provide OAuth authentication for the caldav provider, likely special cased on the hostname.

I've tested this already with a static auth key and the caldav endpoint works fine. I just need to flash the OAuth window. Thunderbird has some OAuth code already, but last I tried this needs some modifications to work with Google's OAuth implementation.

I had hoped I can use nsIHttpAuthenticator, but its synchronous and Google doesn't provide the right values on a 401.

*** This is confidential, please leave this bug secure ***

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This should take care. I don't know if all Google accounts secretly have this enabled yet, but if you can I'd appreciate some testing.

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 727694 [details] [diff]
Fix - v1

Looks like the patch is missing a file.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Ah yes, here is the patch with file

Comment 4

[Matthew Mecca [:mmecca]]

It looks like the host name that triggers the use of OAuth is "apidata.googleusercontent.com". What URL do you need to use for the calendar location to use v2 of the API?

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://apidata.googleusercontent.com/caldav/v2/[calid]/events

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

For this to be public, I'm going to have to apply some obfuscation to the part of the code that holds the OAuth secrets. I've discussed this with the Google folks and we have come to a solution that works for both of us. Patch coming soon.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 723ed450d2e7

Comment 10

[Stefan Sitter [:ssitter]]

From a quick test this seems to work but I noticed a problem after setting up a master password in Thunderbird. Thunderbird will not startup anymore, the master password prompt will appear partially but is not operable and Thunderbird uses 100 % CPU cycles. Thunderbird starts fine again if I switch off the calendar by setting "calendar.registry.<id>.disabled" to true for the calendar.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Mmh that doesn't sound too good. These master passwords are really a pain! Any idea why its happening?

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The moz.build info was missing, probably due to bitrot. Bustage fix here:

https://hg.mozilla.org/comm-central/rev/6f04beca8b73
https://hg.mozilla.org/releases/comm-aurora/rev/d5da57105c97

Comment 13

[Stefan Sitter [:ssitter]]

Do you consider this feature public now, i.e. we can go ahead and file public bugs for missing features or enhancement requests or problems like mentioned in comment 10? Or should they be filed as security hidden?

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Go ahead and file public bugs, just keeping this one private because it contains the key in plaintext.