Closed Bug 853242 Opened 8 years ago Closed 8 years ago

Move "MODULE" in DOM Inspector Makefiles to moz.build files

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

Details

Attachments

(1 file)

See Bug 844654 and http://hg.mozilla.org/mozilla-central/rev/97e443115162, the MODULE directive needs to be moved to the new moz.build files.
Attached patch PatchSplinter Review
Now that was easy to fix (I hope I got it right).
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #727444 - Flags: review?(gps)
OS: Windows XP → All
Hardware: x86 → All
Comment on attachment 727444 [details] [diff] [review]
Patch

Review of attachment 727444 [details] [diff] [review]:
-----------------------------------------------------------------

I would have also accepted the complete removal of MODULE because it likely doesn't do anything for this file.
Attachment #727444 - Flags: review?(gps) → review+
Pushed: http://hg.mozilla.org/dom-inspector/rev/5e221dff8f93
(Target Milestone not really accurate for DOMI, but setting anyway)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.