853300 - click on android's menu button should bring up the toolbar if its hidden in dynamic mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mathieu Pellerin]

It'd be nice that, in addition to panning upwards to have the dynamic toolbar show, when the user clicks on android's menu button, the toolbar is shown if hidden. 

That'd match up with samsung galaxy s3 / note2 / etc. stock browser.

Comment 1

[Chris Lord [:cwiiis]]

I agree. This should be pretty easy to implement...

Comment 2

[Aaron Train [:aaronmt]]

Probably want an Ian opinion here

Comment 3

[Ian Barlow (:ibarlow)]

Seems reasonable to me.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Show toolbar when hw menu button is pressed

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 727736 [details] [diff] [review]
Show toolbar when hw menu button is pressed

Review of attachment 727736 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. This line would require a change if attachment #727704 [details] [diff] [review] gets applied.

Comment 6

[Chris Lord [:cwiiis]]

(In reply to Chris Lord [:cwiiis] from comment #5)
> Comment on attachment 727736 [details] [diff] [review]
> Show toolbar when hw menu button is pressed
> 
> Review of attachment 727736 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM. This line would require a change if attachment #727704 [details] [diff] [review]
> [diff] [review] gets applied.

Actually, it wouldn't - ignore me.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/649f6d85d616

Comment 8

[Aaron Train [:aaronmt]]

Do we want or have a software menu-alternative? Or will this be alleviated via bug 708765?

Comment 9

[Chris Lord [:cwiiis]]

(In reply to Aaron Train [:aaronmt] from comment #8)
> Do we want or have a software menu-alternative? Or will this be alleviated
> via bug 708765?

You don't need to scroll to the top of the page to reveal the menu button, why would we need this? (you currently do if you're using a mouse-wheel/trackpad, but we can fix that) I may well have misunderstood what you mean...

Comment 10

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/649f6d85d616