Closed
Bug 853300
Opened 11 years ago
Closed 11 years ago
click on android's menu button should bring up the toolbar if its hidden in dynamic mode
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: nirvn.asia, Unassigned)
References
Details
Attachments
(1 file)
968 bytes,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
It'd be nice that, in addition to panning upwards to have the dynamic toolbar show, when the user clicks on android's menu button, the toolbar is shown if hidden. That'd match up with samsung galaxy s3 / note2 / etc. stock browser.
Reporter | ||
Updated•11 years ago
|
Blocks: dynamic-toolbar
Comment 1•11 years ago
|
||
I agree. This should be pretty easy to implement...
OS: Windows 7 → Android
Hardware: x86 → All
Comment 4•11 years ago
|
||
Attachment #727736 -
Flags: review?(chrislord.net)
Comment 5•11 years ago
|
||
Comment on attachment 727736 [details] [diff] [review] Show toolbar when hw menu button is pressed Review of attachment 727736 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. This line would require a change if attachment #727704 [details] [diff] [review] gets applied.
Attachment #727736 -
Flags: review?(chrislord.net) → review+
Comment 6•11 years ago
|
||
(In reply to Chris Lord [:cwiiis] from comment #5) > Comment on attachment 727736 [details] [diff] [review] > Show toolbar when hw menu button is pressed > > Review of attachment 727736 [details] [diff] [review]: > ----------------------------------------------------------------- > > LGTM. This line would require a change if attachment #727704 [details] [diff] [review] > [diff] [review] gets applied. Actually, it wouldn't - ignore me.
Comment 7•11 years ago
|
||
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/649f6d85d616
Comment 8•11 years ago
|
||
Do we want or have a software menu-alternative? Or will this be alleviated via bug 708765?
Comment 9•11 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #8) > Do we want or have a software menu-alternative? Or will this be alleviated > via bug 708765? You don't need to scroll to the top of the page to reveal the menu button, why would we need this? (you currently do if you're using a mouse-wheel/trackpad, but we can fix that) I may well have misunderstood what you mean...
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/649f6d85d616
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•