853339 - [fireplace] Scroll position should(?) reset to top upon navigating cached pages

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

1. Scroll down.
2. Click a category.
3. Go back to homepage.
4. Click a category again (same/different/whatever).
5. Notice the scroll position is the same as it was in step #2.

We're pushState-ing the scrollTop, so I guess it makes sense to have this behaviour when going back/forward in history. But what if the context is different? What if I get linked to the same app from a search results page, for example. Is that the correct expected behaviour?

It's worth noting that the scroll position gets reset (since there is none) when accessing a page that hasn't been cached yet. For example:
1. Go to http://localhost:8675/
2. Click a category.

Comment 1

[Matt Basta [:basta]]

Is this still reproducible?

Comment 2

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/6f5382fdea0b2557870f9fcb8cb13590e910ce1c