853340 - getTextAtOffset for word boundaries: beginning of a new life

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

1) separate implementation for getTextAt word boundaries (not nice, I will reorg things during getTextAfter/Before work)
2) fix one case in GetPosAndText

The patch fixes bunch of cases and introduce couple regressions:
* couple regressions in getTextAfter/BeforeOffset because of GetPosAndText change (they don't seem important since these methods don't work in general)
* couple regressions in getTextAtOffset - layout says us hi (I will file bug for those)

Comment 1

[alexander :surkov (:asurkov)]

Trev, I need mochitests from bug 852021 before this. Also please don't be picky about this patch. It's in the middle of the work.

Comment 2

[alexander :surkov (:asurkov)]

What did we decide? Should I wait with landing until merging?

Comment 3

[Marco Zehe (:MarcoZ)]

(In reply to alexander :surkov from comment #2)
> What did we decide? Should I wait with landing until merging?

No, go ahead and land this now. We have a full week to solidify it still, that's good enough for me.

Comment 4

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/392c55ce512d

Comment 5

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/392c55ce512d

Comment 6

[Trevor Saunders (:tbsaunde)]

so linux pgo builds started failing on this push in dom bindings while I don't really think its at fault I backed it out anyway in https://hg.mozilla.org/integration/mozilla-inbound/rev/3fd95a7e87de just to be sure

Comment 7

[Phil Ringnalda (:philor)]

Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/abef045c80bc once you turned out to be a completely innocent bystander.

Comment 8

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/abef045c80bc