Closed Bug 853340 Opened 7 years ago Closed 7 years ago

getTextAtOffset for word boundaries: beginning of a new life

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
1) separate implementation for getTextAt word boundaries (not nice, I will reorg things during getTextAfter/Before work)
2) fix one case in GetPosAndText

The patch fixes bunch of cases and introduce couple regressions:
* couple regressions in getTextAfter/BeforeOffset because of GetPosAndText change (they don't seem important since these methods don't work in general)
* couple regressions in getTextAtOffset - layout says us hi (I will file bug for those)
Trev, I need mochitests from bug 852021 before this. Also please don't be picky about this patch. It's in the middle of the work.
Attachment #727551 - Flags: review?(trev.saunders)
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #727551 - Flags: review?(trev.saunders) → review+
What did we decide? Should I wait with landing until merging?
(In reply to alexander :surkov from comment #2)
> What did we decide? Should I wait with landing until merging?

No, go ahead and land this now. We have a full week to solidify it still, that's good enough for me.
https://hg.mozilla.org/mozilla-central/rev/392c55ce512d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
so linux pgo builds started failing on this push in dom bindings while I don't really think its at fault I backed it out anyway in https://hg.mozilla.org/integration/mozilla-inbound/rev/3fd95a7e87de just to be sure
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/abef045c80bc once you turned out to be a completely innocent bystander.
https://hg.mozilla.org/mozilla-central/rev/abef045c80bc
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.