853362 - [Leo][tara] Camera switch icon and flash icon are covered by filmstrip

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Dafeng Xu]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22

Steps to reproduce:

Click in the preview area


Actual results:

part of the front and rear camera toggle button is covered

Comment 1

[Casey Yee]

Can you attach a screen shot?  I'm not sure what you are referring to as we don't have a button to switch between front and rear cameras.    This is of course because we only have a back facing camera on our current development phones :)

Comment 2

[Dafeng Xu]

Attachment: The screen shot of camera application

The screen shot of camera application

Comment 3

[Dafeng Xu]

Attachment: The screen shot of camera application

The second screen shot of camera application

Comment 4

[Dafeng Xu]

I just add the screen shot to the bugzilla, In the 1.jpg, you can see the camera switch icon is partially covered.

Comment 5

[Ben Tian (inactive)]

Attachment: filmstrip+icons on unagi

:cyee, I also attach the screenshot on unagi (I hacked the app to show icons for demo only).

I wonder what's the UX design to show filmstrip and icons on screen simultaneously. With the UX design we can resolve this bug in our desired way, either modifying the layout or leaving it by design.

Comment 6

[Ben Tian (inactive)]

:cyee. Any update on desired UX design?

Comment 7

[Casey Yee]

We don't have a UX design that includes flash or camera flip functions since our working devices do not support these features.  

(In reply to Ben Tian [:btian] from comment #5)
> With the UX design we can resolve this bug in our desired
> way, either modifying the layout or leaving it by design.

We are open to any design or layout ideas that you might have for this one.    For now it's not a priority for us so it may be a while before we update the design to include these features.

Comment 9

[Ben Tian (inactive)]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/9775

cyee, please review my change that moves those icons down. Attach screenshots on leo and tara.

Comment 10

[Michael Wu [:mwu]]

(In reply to Casey Yee [:cyee] from comment #7)
> We don't have a UX design that includes flash or camera flip functions since
> our working devices do not support these features.  
> 

We actually do have at least one that supports flash. We should make a decision as to whether we're ok with this or if we want to fix it for 1.1..

Comment 11

[Casey Yee]

I'd like to know if there are phones in the current 1.1 or 1.2 that will be requiring these features.   The intention was to re-design the camera app so that it includes these buttons, but it's not clear to me what timeline we need these in.  

For demo or testing purposes, what Ben has created is fine but we should create a new design before this gets committed to production builds.

Comment 12

[Peter Dolanjski [:pdol]]

(In reply to Casey Yee [:cyee] from comment #11)
> I'd like to know if there are phones in the current 1.1 or 1.2 that will be
> requiring these features.   

Yes, a shipping 1.1 device will have a camera flash.

Comment 13

[Stephany Wilkes]

What is the deadline/intended release for this? UX is focusing its efforts on leo+ and tef+ blockers, so knowing this will help us prioritize for this bug. Thanks!

Comment 14

[Ben Tian (inactive)]

Stephany, Leo is the shipping 1.1 device with a camera flash.

Wayne, should this bug be leo+? If so, what's the deadline if we has to solve this bug?

Comment 15

[Wayne Chang [:wchang]]

Stephany, Casey,
Where possible we should try to get this in for the CS patch, deadline being code frozen on June 7th.
As already mentioned above, there will be one device with flash and there will be possibly another with a front camera with 1.1.

Comment 16

[Dale Harvey (:daleharvey)]

Ill take this one, we already had UI in that it just sat below the filmstrip, it got regressed during the hdpi work I believe since it wasnt testable but I have a leo now so will put a patch in for this tomorrow

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocking for now, but after June 7th we would need a partner champion/milestone.

Comment 18

[Stephany Wilkes]

Thanks, Dale. If you already have UI that got regressed, I'm going to clear the flag for additional UI on this. Since this is blocking, PLEASE let me know ASAP if that needs to change and additional UI work is needed here.

Comment 19

[Dale Harvey (:daleharvey)]

Attachment: Pointer to GH

Comment 20

[David Flanagan [:djf]]

Comment on attachment 754938 [details]
Pointer to GH

r=djf for github commit  e0db993 

But please change the transition to use transform:translateY() instead of transitioning on the top property.

Comment 21

[Dale Harvey (:daleharvey)]

Comments addressed and merged in: https://github.com/mozilla-b2g/gaia/commit/6b75dbb7888acc7d094ae60c0302df7d49e056d7

Comment 22

[Dale Harvey (:daleharvey)]

Comment on attachment 749627 [details]
link to https://github.com/mozilla-b2g/gaia/pull/9775

Apologies for missing this btian, you should mark davidflanagan or I as reviewers and needinfo casey (or firefox+ux) as they wont be able to review bug can give feedback, they will also likely need a screenshot as opposed to a commit. Pull requests that are waiting on a review flag shouldnt get missed

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 6b75dbb7888acc7d094ae60c0302df7d49e056d7
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 24

[Dale Harvey (:daleharvey)]

Uplifted in: https://github.com/mozilla-b2g/gaia/commit/7ba1a6791fdf038a962eb9e11e64f43232f2ad83

Comment 25

[:CSchmoeckel]

Added Camera Suite Test Case #8748 [Camera] The filmstrip preview overlay does not overlap with the Switch Camera and Flash icons

Comment 26

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 7ba1a6791fdf038a962eb9e11e64f43232f2ad83

Comment 27

[Cody Roesch [:croesch]]

Verified as fixed on the leo device with variables below. When a picture is taken and the filmstrip appears at the top, the icon for flash will adjust downward to avoid the filmstrip.

Environmental Variables
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158