853379 - update contact activity should allow adding email to existing contact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[satender]

In order for user to be able to add email address from within SMS message, contacts activity 'update' needs to support taking an email address and updating the contact.

Comment 1

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8741

Pointer to Github pull-request

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 727660 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8741

Code looking great, tested on the phone working perfect.

Thanks!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/7eecff10bace87bc886fa8a50ad3ee0b1efcfc55

Comment 4

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8748

Pointer to Github pull-request

Comment 5

[alberto.pastor]

(In reply to Alberto Pastor [:albertopq] from comment #4)
> Created attachment 727730 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8748
> 
> Pointer to Github pull-request

There was a bug on the previous merged patch (trying to create a new contact with params), that is fixed in the new one.

Comment 6

[Jason Smith [:jsmith]]

Don't know who owns this. Tony - Can you find out who owns developing test coverage for this?

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

this is a modification of the contacts apps, which is owned by TEF.

The patch is looking good but since we don't have an application creating a new contact just with email we would like to add a test case on the ui tests to be tested.

Cheers,
F.

Comment 8

[Tony Chung [:tchung]]

attention: Tef QA, to help track a testcase.

Comment 9

[mbarone]

This feature is part of the US 838004. TEF is tracking the test cases for this feature

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 727730 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8748

Now yes :)

All the cases working well.

Thanks Alberto!

Comment 11

[alberto.pastor]

https://github.com/mozilla-b2g/gaia/commit/05e2f93757eaaf553894ebd1157de5d2cb10d4fe

Comment 12

[Jason Smith [:jsmith]]

Unflagging in-moztrap - the bug this blocks is already tracking the work.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 7eecff10bace87bc886fa8a50ad3ee0b1efcfc55 as:
v1-train: a61fb82d658047a2eaeed693ad07215bd7245d36
Uplifted commit 05e2f93757eaaf553894ebd1157de5d2cb10d4fe as:
v1-train: a790faea8dcc7f915f54ee09948ab22a783e6257