85346 - Character display garbage in Page Source windows if use context menu

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P2)

Description

[Sagie Maoz]

Mozilla page source windows shows Hebrew text with wrong characters, instead of
the normal Hebrew letters.

Comment 1

[Katsuhiko Momoi]

I am going to confirm this bug because I believe there is a bug 
in our code which somhow corrupts source display when auto-detection
is on. It does not use the fotn for the determined encoding by a 
meta tag. 

I think there is a bug somewhere for which this one is a duplicate.
For example, I tried the following page:

http://www.masa.co.il/

with View | Character Coding | Auto-Detect | Off

The page source looked OK under this setting. 

It is possible that Sagie is seeing this problem. But to really see
the cause of the reported problem, we need an actual URL.
Sagie, please provide the URL of a page which has a problem.

CC'ing nhotta and ftang to see if there is a duplicate somewhere.

Comment 2

[Sagie Maoz]

Win98 Build 2001060703

Auto-Detect is set to (off) here and still no hebrew characters in source window.

Comment 3

[Sagie Maoz]

the url was http://www.masa.co.il

Comment 4

[Sagie Maoz]

Sorry for tripple-messaging, but I just checked http://www.guides.co.il/ and the
Page Source looks good, with the proper Hebrew fonts.

Comment 5

[Simon Montagu :smontagu]

I see this bug on www.masa.co.il if I use "View Frame Source" from the context
menu after right-clicking in the middle of the page (in the area with the
graphics of grapes, Sherlock Holmes, etc).

If I open that frame separately using "Open Frame in New Window" or "Show Only
This Frame" and then "View Page Source", the Hebrew is displayed correctly.

Auto-detection is off for me.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Looks like the context menu "View Frame Source" option does not inherit the
character set of the main document like the "View" menu "View Source" option
does.  Patch coming up.

I can't test it at the moment since Mozilla crashes when I try to bring up a
context menu on the pages in question.  But it should solve this problem...

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: patch to fix this

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK, I hunted down and killed that crash (it was in another chunk of code in my
tree that I've modified) and tested this patch.  Works great for me.  The code
is modeled on the BrowserViewSource() function in navigator.js

Reviews?  Ccing blake, since this is context menu code.

Comment 9

[Katsuhiko Momoi]

This is really not Bidi specific issue and needs to be reviewed
by i18n component owner. Changed the component accordingly. 
Re-assigned to ftang. QA contact changed.

Comment 10

[Andreas Becker]

Adding keyword intl.

Switching QA contact to [e-mail].

Comment 11

[Frank Tang]

r=ftang
need sr.

Comment 12

[Frank Tang]

change summary to "Character display garbage in Page Source windows if use 
context menu"

Comment 13

[Frank Tang]

change status to "r=ftang , ask alecf to sr= (6/19 9:50) need a="

Comment 14

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 16

[Boris Zbarsky [:bzbarsky]]

Fix checked in.

Comment 17

[Yuying Long]

Verified on 08-24 trunk  build on Wind2k-zh and Linux RH6.2-Ja, the page source
looks OK now.