853470 - 500 erros for grants urls

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect, P3)

Description

[Paul [:pmac] McLanahan]

Been getting some tracebacks (see below) for URLs like http://www.mozilla.org/en-US/grants/2008/. Any non-recognized grants url (like grants/2008/) should redirect to /grants/. But the redirect is broken because it's passing the view function instead of the view name to the redirect helper.


Traceback (most recent call last):

  File "/data/www/www.mozilla.org-django/bedrock/vendor-local/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/www.mozilla.org-django/bedrock/apps/redirects/util.py", line 47, in _view
    return redirect_class(redirect_url)

  File "/data/www/www.mozilla.org-django/bedrock/vendor-local/src/django/django/http/__init__.py", line 655, in __init__
    parsed = urlparse(redirect_to)

  File "/usr/lib64/python2.6/urlparse.py", line 129, in urlparse
    tuple = urlsplit(url, scheme, allow_fragments)

  File "/usr/lib64/python2.6/urlparse.py", line 168, in urlsplit
    i = url.find(':')

AttributeError: 'HttpResponse' object has no attribute 'find'

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f89308b26fd2988559d8f0db4523669ceb187101
Bug 853470: Fix server errors for grants pages.

https://github.com/mozilla/bedrock/commit/d797851af9b512fbf3a8b6bc109ad3605cfd82f8
Merge pull request #698 from pmclanahan/bug-853470-fix-grants-redirect

Bug 853470: Fix server errors for grants pages.

Comment 2

[Paul [:pmac] McLanahan]

Fixed in production.