853486 - Loader animation is not displayed when "More" button is pressed

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Cristian Boldan]

Attachment: more button loader

Steps to reproduce:
1. Launch MP-dev app on FF OS (Unagi)
2. Click on a listed category (ex. Games)
3. Scroll to the bottom of the page and click the "More" button

Expected results:
Loader animation is displayed until the rest of the list is loaded.

Actual results:
Loader animation is missing.

Notes/Issues:
Verified on FF OS (Unagi). Issue is not reproducing on Android or Desktop.
Attaching screenshot for this issue.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Is this still an issue?

Comment 2

[Cristian Boldan]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> Is this still an issue?

Yes. I can still reproduce this issue on my Unagi device on the latest MP-dev app. Loader is still not visible after the "More" button is pressed.

Comment 3

[Matt Basta [:basta]]

Davor rewrote the pagination button code in Fireplace. Please test there. I have not been able to repro this issue on an unagi in Fireplace.

Comment 4

[Cristian Boldan]

I have verified in Fireplace https://marketplace-altdev.allizom.org/ on FF OS browser and this issue is no longer reproducing. The loader is now visible.

Comment 5

[Matt Basta [:basta]]

So let it be written, so let it be done.

Comment 6

[krupa raj[:krupa]]

i can still reproduce this issue on Firefox OS phone using the altdev app.

Comment 7

[Matt Basta [:basta]]

It is possible that the spinner graphic simply isn't loaded yet.

cvan: would you be upset about putting the spinner as a data URI in the include.css?

.spinner {background-image: url(data:...);}

Comment 8

[Christopher Van Wiemeersch [:cvan]]

basta, yeah do that

Comment 9

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/2041a850afc7744d79df0343b7a10e7cdc12bcff

This puts the graphic right in the CSS. If it *still* doesn't work, I'm thinking it's a platform glitch and we'll need to do some further debuggery.

Comment 10

[Cristian Boldan]

The issue is still reproducing in MP altdev app (Fireplace) on Unagi. Loader is still not visible.

Comment 11

[Matt Basta [:basta]]

I don't think there's anything else we can do here. It's a platform bug then, same as the other tranform/position/transition bugs. The image is there, it's spinning, but it's not being displayed. We know it *should* work because it works on desktop, Chrome, all manner of mobile browsers, except Firefox OS.

Cvan: what's your take?

Comment 12

[Wil Clouser [:clouserw]]

If there is a platform bug on file we've done what we can.  Can we make this dependent on it?

Comment 13

[Matt Basta [:basta]]

There are about three that are filed (all with similar but slightly different STR), but the platform team hasn't narrowed down or triaged any of them. Do you want me to scorched earth this bug and make it dependant on all of them?

Comment 14

[Wil Clouser [:clouserw]]

if it's easy, otherwise one works

Comment 16

[Matt Basta [:basta]]

Can you reproduce this on 1.0.1?

Comment 17

[Iulian Timis]

I can no longer reproduce this issue on my Unagi 1.0.1

Comment 18

[Matt Basta [:basta]]

r wfm since the bug seems to have been fixed and uplifted to 1.0.1