Closed
Bug 853490
Opened 11 years ago
Closed 11 years ago
No end-of-gesture event is sent on pinch zoom on Windows
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: waterlo1, Assigned: waterlo1)
Details
Attachments
(1 file)
1.69 KB,
patch
|
jimm
:
review+
masayuki
:
feedback+
|
Details | Diff | Splinter Review |
On Windows, pinch-to-zoom events (MozMagnifyGesture*) aren't ended with a MozMagnifyGesture event (the end-of-gesture event). This is the case on Mac. Mac does this: MozMagnifyGestureStart MozMagnifyGestureUpdate* MozMagnifyGesture Windows should behave the same way, noting the end of gesture with a MozMagnifyGesture event.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → waterlo1
Assignee | ||
Comment 1•11 years ago
|
||
Essentially just need to add another block to here: http://dxr.mozilla.org/mozilla-central/widget/windows/nsWinGesture.cpp#l328 Can model after the rotate-end below it.
Assignee | ||
Comment 2•11 years ago
|
||
This patch adds an else if block to check to see if the event is an end-of-gesture event on pinch zoom, so that Windows sends MozMagnifyGesture at the end of pinch zoom gesture, as OS X does.
Attachment #728353 -
Flags: feedback?(jAwS)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Attachment #728353 -
Flags: feedback?(jAwS) → feedback?(masayuki)
Comment 3•11 years ago
|
||
Hmm, I'm not familiar with gesture events, however, it's probably important for me for other related DOM events. So, I'll check it next week as far as possible. Thanks.
Comment 4•11 years ago
|
||
Comment on attachment 728353 [details] [diff] [review] Proposed patch v1 Looks like no problem. However, I'm not sure whether it's worthwhile or not to update mZoomIntermediate at the end of the gesture, though. Sorry for taking this very long time.
Attachment #728353 -
Flags: feedback?(masayuki) → feedback+
Assignee | ||
Comment 5•11 years ago
|
||
My thought with updating mZoomIntermediate (thought it will not likely be used) is to include it anyway--whoever is listening for the event can choose to use that value or not. If it was not included, then they have no choice.
Assignee | ||
Updated•11 years ago
|
Attachment #728353 -
Flags: review?(jAwS)
Updated•11 years ago
|
Attachment #728353 -
Flags: review?(jAwS) → review?(jmathies)
Updated•11 years ago
|
Attachment #728353 -
Flags: review?(jmathies) → review+
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/574122faa485
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/574122faa485
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•