85355 - XPCWrappedNative::ToString should sometimes yield '[object Foo]'

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[John Bandhauer]

I'm thinking that in the case where a wrappedNative object has a scriptable 
helper (and thus a custom JSClass name) we should name the default ToString 
function yield '[object Foo]' rather than '[xpconnect wrapped Foo]'. I imagine 
this might give us better backward compatibility for misc. DOM objects. If 
nothing else this might limit confusion.

This is easy to change and I think we should just do it before the next major 
release.

Comment 1

[David Bradley]

Attachment: One liner to change the text of toString

Comment 2

[David Bradley]

Needs sr/r

Comment 3

[David Bradley]

Attachment: Changed to only return object ToString for only wrapped natives with class info

Comment 4

[David Bradley]

Third times a charm. Here's the "final" patch. It tests based on the scriptable 
info, not the class info.

Comment 5

[David Bradley]

Attachment: Changes ToString to print object from xpconnect wrapped native

Comment 6

[Johnny Stenback (:jst)]

sr=jst for the last patch.

Comment 7

[Patrick C. Beard]

r=beard

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers)

Comment 9

[Robert Ginda]

Checked in.

Comment 10

[Phil Schwartau]

Marking Verified -