Closed
Bug 853777
Opened 11 years ago
Closed 11 years ago
CodeGenerator.cpp:1542:16: warning: unused variable ‘cx’ [-Wunused-variable]
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
955 bytes,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
New build warning (encountered in my m-i build today, though I think it affects m-c too now): { /mozilla/js/src/ion/CodeGenerator.cpp: In member function ‘virtual bool js::ion::CodeGenerator::visitApplyArgsGeneric(js::ion::LApplyArgsGeneric*)’: /mozilla/js/src/ion/CodeGenerator.cpp:1542:16: warning: unused variable ‘cx’ [-Wunused-variable] } Link to MXR: https://mxr.mozilla.org/mozilla-central/source/js/src/ion/CodeGenerator.cpp#1542 The variable is indeed unused -- it was orphaned by bug 849388, which removed the last usage of it, here: https://hg.mozilla.org/mozilla-central/rev/2b9b303c9161#l2.40 The variable presumably can just be dropped.
Assignee | ||
Comment 1•11 years ago
|
||
This fixes it.
Comment 2•11 years ago
|
||
Comment on attachment 728103 [details] [diff] [review] fix Review of attachment 728103 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for taking care of this. Sorry for introducing the warning.
Attachment #728103 -
Flags: review?(kvijayan) → review+
Assignee | ||
Comment 3•11 years ago
|
||
No problem - thanks for the quick review turnaround. https://hg.mozilla.org/integration/mozilla-inbound/rev/a614c0fa8f76
Flags: in-testsuite-
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a614c0fa8f76
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•