CodeGenerator.cpp:1542:16: warning: unused variable ‘cx’ [-Wunused-variable]

RESOLVED FIXED in mozilla22

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla22
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
New build warning (encountered in my m-i build today, though I think it affects m-c too now):

{
/mozilla/js/src/ion/CodeGenerator.cpp: In member function ‘virtual bool js::ion::CodeGenerator::visitApplyArgsGeneric(js::ion::LApplyArgsGeneric*)’:

/mozilla/js/src/ion/CodeGenerator.cpp:1542:16: warning: unused variable ‘cx’ [-Wunused-variable]
}

Link to MXR: 
https://mxr.mozilla.org/mozilla-central/source/js/src/ion/CodeGenerator.cpp#1542

The variable is indeed unused -- it was orphaned by bug 849388, which removed the last usage of it, here:
https://hg.mozilla.org/mozilla-central/rev/2b9b303c9161#l2.40

The variable presumably can just be dropped.
(Assignee)

Comment 1

5 years ago
Created attachment 728103 [details] [diff] [review]
fix

This fixes it.
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #728103 - Flags: review?(kvijayan)
Comment on attachment 728103 [details] [diff] [review]
fix

Review of attachment 728103 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this.  Sorry for introducing the warning.
Attachment #728103 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 3

5 years ago
No problem - thanks for the quick review turnaround.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a614c0fa8f76
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/a614c0fa8f76
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.