Closed Bug 853787 Opened 11 years ago Closed 11 years ago

Report errors in nested event loops in xpcshell tests

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: past, Assigned: past)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

Patch v1
1.14 KB, patch
jimb
: review+
Details | Diff | Splinter Review 
When an xpcshell test fails due to an error in a nested event loop (when the debuggee is paused), the test harness is not notified and just times out after a while.

This is especially troublesome in our build infrastructure, because failing tests never output a useful log to figure out what happened. When running locally one can always send a SIGINT (Ctrl-C) after a while and stop the test while seeing the output log. We should either simulate that behavior in the test harness (SIGINT before SIGKILL), or have the XPCOM component collect the errors and resume execution to fail the test immediately.
Attached patch Patch v1 — — Splinter Review 
This makes our test case work. If we exit any nested event loops when the test is about to fail, it finishes normally.
Assignee: nobody → past
Status: NEW → ASSIGNED
Attachment #733524 - Flags: review?(jimb)
Attachment #733524 - Flags: review?(jimb) → review+
https://hg.mozilla.org/mozilla-central/rev/c54b8b913a70
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.