853829 - Gaia language/locale list changes after |make reset-gaia| on pvt build

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Florin Strugariu [:Bebe]]

STR:

1. Flash phone with nightly v1-train branch
2. Check language list 
3. get github gaia repo: https://github.com/mozilla-b2g/gaia
4. checkout v1-train branch
5. make reset gaia
6. Check language list

Expected:
6. the same language list should be available after the reset

Actual:
6: Only 4 languages are available

Comment 1

[Jason Smith [:jsmith]]

Can you reproduce this when flashing a build from pvtbuilds?

Comment 2

[Zac C (:zac)]

If you replace step 1 with a build from pvtbuilds and complete the remaining steps you will get the same Actual result.

Comment 3

[Zac C (:zac)]

Attachment: Screenshot after initial flash from pvt ENG build

Comment 4

[Zac C (:zac)]

Attachment: Screenshot after |make reset-gaia| on top of pvt ENG build

Comment 5

[[:fabrice] Fabrice Desré]

SO, pvt builds are multi-locale builds while yours is not. That's why you see this difference.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Can we get instructions on how to get parity with both types of builds?

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I believe Gaia is creating a profile with just four locales by default as defined in https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/languages.json

According to https://github.com/mozilla-b2g/gaia/blob/master/locales/README.md we should be able to specify a different languages file using the environment variable LOCALES_FILE set to something like locales/languages_basecamp.json

It would be worth finding out what language file pvtbuilds is using so we can match that. Alternatively, we can simply write our tests to expect the reduced language list.

Comment 8

[Staś Małolepszy :stas]

Previous comments are correct:  pvt builds are multilocale (i.e. they have more locales enabled than the git default and also use the up-to-date l10n files), while |make reset-gaia| with no additional flags creates a stripped down version of the build with just ar, en-US, fr and zh-TW (these locales are actually checked into git, so that you can build Gaia with more than one locale right after cloning the repo).

To enable more locales, follow the instructions here:

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Building#Building_multilocale

The pvt builds use locales/languages_dev.json on all branches.  For v1.0.1 it will likely stay that way, but for future branches, I'd like to rename the config files; see bug 853134.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

We could do this for our UI test jobs but it would require cloning the 17 locale repositories for every build. Is this needed, or can we use one of the languages common to both Gaia default and the pvtbuilds? If there's a particular locale needed, perhaps it could be added to the Gaia defaults?

Comment 10

[Zac C (:zac)]

That does seem a bit overkill.
I was asked to use Brazillian Portugese for the test case but with regard to testing functionality it's not important.
Let's switch it to French.

Comment 11

[Florin Strugariu [:Bebe]]

Done in https://github.com/mozilla/gaia-ui-tests/pull/595

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

So, Zac, Bebe -- anything left here for anybody on this bug to do given that we've switched the language in comment 11?

Comment 13

[Zac C (:zac)]

Nothing to do in this bug.