853857 - crash in CrashReporter::CheckForLastRunCrash

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, critical)

Description

[Scoobidiver (away)]

There's one crash in 22.0a1/20130321.

Signature 	CrashReporter::CheckForLastRunCrash() More Reports Search
UUID	05f1aefe-4024-4e22-8ac3-998922130321
Date Processed	2013-03-21 18:52:32
Uptime	1
Last Crash	1.9 weeks before submission
Install Age	1 seconds since version was first installed.
Install Time	2013-03-21 18:52:11
Product	MetroFirefox
Version	22.0a1
Build ID	20130321030940
Release Channel	nightly
OS	Windows NT
OS Version	6.2.9200
Build Architecture	x86
Build Architecture Info	AuthenticAMD family 16 model 2 stepping 3
Crash Reason	EXCEPTION_ACCESS_VIOLATION_READ
Crash Address	0x0
App Notes 	
AdapterVendorID: 0x10de, AdapterDeviceID: 0x0611, AdapterSubsysID: 1a011019, AdapterDriverVersion: 9.18.13.1407
D2D! D2D+ DWrite? DWrite+ D3D10 Layers! D3D10 Layers+ 
Processor Notes 	sp-processor05.phx1.mozilla.com_16345:2008; WARNING: JSON file missing Add-ons
EMCheckCompatibility	True
Adapter Vendor ID	0x10de
Adapter Device ID	0x0611
Total Virtual Memory	4294836224
Available Virtual Memory	3941478400
System Memory Use Percentage	40
Available Page File	5698408448
Available Physical Memory	2561630208
Accessibility	Active

Frame 	Module 	Signature 	Source
0 	xul.dll 	CrashReporter::CheckForLastRunCrash 	toolkit/crashreporter/nsExceptionHandler.cpp:2423
1 	xul.dll 	CrashReporter::GetLastRunCrashID 	toolkit/crashreporter/nsExceptionHandler.cpp:2448
2 	xul.dll 	nsXULAppInfo::GetLastRunCrashID 	toolkit/xre/nsAppRunner.cpp:838
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70
4 	xul.dll 	XPC_WN_GetterSetter 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1465
5 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:384
6 	mozjs.dll 	js::Invoke 	js/src/jsinterp.cpp:431
7 	mozjs.dll 	js::GetPropertyOperation 	js/src/jsinterpinlines.h:295
8 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2246
9 	mozjs.dll 	js::RunScript 	js/src/jsinterp.cpp:341
10 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:398
11 	mozjs.dll 	js::Invoke 	js/src/jsinterp.cpp:431
12 	mozjs.dll 	JS_CallFunctionValue 	js/src/jsapi.cpp:5764
13 	xul.dll 	nsXPCWrappedJSClass::CallMethod 	js/xpconnect/src/XPCWrappedJSClass.cpp:1433
14 	xul.dll 	nsXPCWrappedJS::CallMethod 	js/xpconnect/src/XPCWrappedJS.cpp:578
...

More reports at:
https://crash-stats.mozilla.com/report/list?signature=CrashReporter%3A%3ACheckForLastRunCrash%28%29

Comment 1

[(not currently active) Ted Mielczarek]

Looks like we probably just need to check if CreateFileFromPath fails:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp#2423

I guess it's possible we have a bad filename in the last-crash file?

Comment 2

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=24396117&tree=Mozilla-Inbound&full=1#error0

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

Comment 4

[Jim Mathies [:jimm]]

Attachment: export

Comment 5

[:ehsan akhgari]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e3e6bbe62bb

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e3e6bbe62bb