853860 - [OS.File] outExecutionDuration should accumulate

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Accumulating outExecutionDuration

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Accumulating outExecutionDuration

Try: https://tbpl.mozilla.org/?tree=Try&rev=3bf243b503af

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 731101 [details] [diff] [review]
Accumulating outExecutionDuration

Review of attachment 731101 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/osfile/osfile_async_front.jsm
@@ +121,5 @@
>  let Scheduler = {
>    post: function post(...args) {
> +    // By convention, the last argument of any message may be an |options| object.
> +    let methodArgs = args[1];
> +    let options = methodArgs?methodArgs[methodArgs.length - 1]:null;

Nit: spaces in your ternary operator bits, please.

::: toolkit/components/osfile/tests/mochi/main_test_osfile_async.js
@@ +908,5 @@
> +
> +    // Trying an operation where options are cloned.
> +    // Options structure passed to a OS.File writeAtomic method.
> +    writeAtomicOptions = {
> +      // This field should be overridden with the actual duration

Nit: overridden or incremented?  The latter, yes?

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Accumulating outExecutionDuration

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=650bc9071a02

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a8d1a910913

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a8d1a910913