[OS.File] outExecutionDuration should accumulate

RESOLVED FIXED in mozilla22

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

Trunk
mozilla22
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

No description provided.
Assignee: nobody → dteller
Attachment #731101 - Flags: review? → review?(nfroyd)
Comment on attachment 731101 [details] [diff] [review]
Accumulating outExecutionDuration

Review of attachment 731101 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/osfile/osfile_async_front.jsm
@@ +121,5 @@
>  let Scheduler = {
>    post: function post(...args) {
> +    // By convention, the last argument of any message may be an |options| object.
> +    let methodArgs = args[1];
> +    let options = methodArgs?methodArgs[methodArgs.length - 1]:null;

Nit: spaces in your ternary operator bits, please.

::: toolkit/components/osfile/tests/mochi/main_test_osfile_async.js
@@ +908,5 @@
> +
> +    // Trying an operation where options are cloned.
> +    // Options structure passed to a OS.File writeAtomic method.
> +    writeAtomicOptions = {
> +      // This field should be overridden with the actual duration

Nit: overridden or incremented?  The latter, yes?
Attachment #731101 - Flags: review?(nfroyd) → review+
Attachment #731101 - Attachment is obsolete: true
Attachment #731160 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/4a8d1a910913
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.