853870 - fix rebuilding individual *Binding.{cpp,h} files

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Nathan Froyd [:froydnj]]

Try the following sequence of steps:

1) Build dom/bindings/.
2) Modify a webidl file of your choice to include an attribute.
3) Copy the corresponding .cpp out of the way.
4) Run make -C dom/bindings/ name_of_file.cpp.
5) Diff the file from step 3 and the file from step 5.
6) Observe no difference.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix regeneration of *Binding.{cpp,h} files when .webidl file changes

This only seems to be a problem for rebuilding individual files.  I suppose there
could be other lurking issues, though...?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Does that not force all .cpp files to be regenerated during a build if _any_ webidl file changed?

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Does that not force all .cpp files to be regenerated during a build if _any_
> webidl file changed?

ParserResults.pkl already depends on all the webidl files right now.  So right now, make should detect that, rebuild ParserResults.pkl and the global headers, then rebuild the .cpp files.  This patch is just making explicit some dependencies that were more roundabout before.

Another alternative would be to make the deps files for the individual .cpp/.h files more accurate by including the global headers.  I think that should have the same effect.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I thought make was rebuilding the .cpp files based on the relevant deps files, so in fact right now a change to webidl will change ParserResults.pkl but NOT rebuild all the .cpp files.

Comment 5

[Nathan Froyd [:froydnj]]

You are correct.  But building individual .cpp files does not work correctly.  Building individual .o files does seem to work correctly.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Fixed by the rewrite?

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.