853909 - No test code exists yet for rotation gesture

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Brandon Waterloo]

No test code exists yet for image rotation gesture.

Comment 1

[Brandon Waterloo]

See also bug 833511

Comment 2

[Brandon Waterloo]

Attachment: Proposed Patch v0.1

This patch will test image rotation 32 times--
-At each 90-degree initial rotation (4 ways)
-Clockwise and counter clockwise (2 ways)
-More and less than 45 degrees rotated (2 ways)
-Stopping before end of gesture (so primitive nearest-snap occurs) and not stopping (so momentum snapping occurs) (2 ways)

4*2*2*2 = 32.

Test code is all in browser/base/content/test/browser_gestureSupport.js.  Test is now async, requires explicit finish.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 728298 [details] [diff] [review]
Proposed Patch v0.1

Review of attachment 728298 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/browser_gestureSupport.js
@@ +545,5 @@
> +
> +  // Force the current rotation on the image, update gGestureSupport so it isn't
> +  // confused, and force flush
> +  aImageElement.style.transform = "rotate(" + aCurrentRotation +"deg)";
> +  gGestureSupport.rotation = aCurrentRotation;

Hm, it would be better if gGestureSupport didn't need to be mucked with here.

@@ +608,5 @@
> +  let clockwise = SimpleGestureEvent.ROTATION_CLOCKWISE;
> +  let cclockwise = SimpleGestureEvent.ROTATION_COUNTERCLOCKWISE;
> +
> +  let imgElem = content.document.body &&
> +                     content.document.body.firstElementChild;

nit, weird indentation here. you can just align the two content.document's.

@@ +640,5 @@
> +{
> +  test_imageTab = gBrowser.addTab("chrome://branding/content/about-logo.png");
> +  gBrowser.selectedTab = test_imageTab;
> +
> +  gBrowser.getBrowserForTab(test_imageTab)

You can use gBrowser.selectedBrowser here.

Comment 4

[Brandon Waterloo]

Attachment: Proposed Patch v0.2

This patch incorporates jaws' feedback.
In order to test at all four possible initial orientations, it is necessary to manually set the rotation--in this case a simple 90 degree clockwise rotate gesture was performed.  This is seen at the end of the loop.  This manual alteration to rotation is not tested, but if any errors occurred, they would be caught by later tests.

The eight gestures performed in the loop (excluding the final manual set gesture) cancel each other out in total--so given an initial rotation of x, the final rotation after all 8 gestures will be x.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 729198 [details] [diff] [review]
Proposed Patch v0.2

Review of attachment 729198 [details] [diff] [review]:
-----------------------------------------------------------------

I ran the tests on Windows and it looks good from here.

::: browser/base/content/test/browser_gestureSupport.js
@@ +557,5 @@
> +    let stopExpectedRotation = (aCurrentRotation + delta) % 360;
> +    if (stopExpectedRotation < 0)
> +      stopExpectedRotation += 360;
> +
> +    ok(stopExpectedRotation == test_rotateHelperGetImageRotation(aImageElement),

is(lhs, rhs, ...)

@@ +583,5 @@
> +    if (finalExpectedRotation < 0)
> +      finalExpectedRotation += 360;
> +  }
> +
> +  ok(finalExpectedRotation == test_rotateHelperGetImageRotation(aImageElement),

is(lhs, rhs, ...)

@@ +593,5 @@
> +}
> +
> +function test_rotateGesturesOnTab()
> +{
> +  gBrowser.getBrowserForTab(test_imageTab)

This is just gBrowser.selectedBrowser

Comment 6

[Brandon Waterloo]

Attachment: Proposed Patch

This version of the patch incorporates jaws' previous feedback.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6cde6ea21d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d6cde6ea21d