853952 - When saving an event that you have edited, the user shall be returned to the calendar view, not the read only view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 3/22/2013
Device: Unagi

Steps:

1. Select to edit an event
2. Make changes and save

Expected:

Per UX, the user should return back to the calendar view the user was previously on.

Actual:

We currently return back to the read only view. This isn't necessarily bad behavior to have right now, but going back to the calendar view felt more natural, so let's do that.

Definitely doesn't need to be tracked or blocked on.

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pull request

Comment 2

[James Lal [:lightsofapollo]]

Comment on attachment 737043 [details]
Pull request

handing off to kevin who did most of the review anyway

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 737043 [details]
Pull request

Thanks for making this hacky on my request.

Comment 4

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/0f1c0be6c8087873c0d362ac38a570c9edb58438

Comment 5

[Jason Smith [:jsmith]]

This is the missing dependency we need to land bug 867797, right?

Comment 6

[James Lal [:lightsofapollo]]

yep

@doliver- can you leo+ this so we can re-uplift 867797

Comment 7

[Dylan Oliver [:doliver]]

leo+ -- required for leo+ QE2 blocker

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0f1c0be6c8087873c0d362ac38a570c9edb58438 to:
v1-train: 7f18822d9319b8d3a43e1c0c439eb4778b77d98f

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 7f18822d9319b8d3a43e1c0c439eb4778b77d98f

Comment 10

[Jason Smith [:jsmith]]

Verified on 6/24 build using provided STR in comment 0.