Closed Bug 853988 Opened 7 years ago Closed 7 years ago

Organize TypeTraits.h the same way C++11 defines <type_traits>

Categories

(Core :: MFBT, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(6 files)

Adding everything mishmashedly makes it harder to find things.
Having all these as one patch leads to a really messed-up diff.  So this is going to be five or so patches -- first to add sectioning, then a bunch to move individual components into position.  All trivial, no functionality change, just makes for easier diff-reading.
Attachment #728390 - Flags: review?(nfroyd)
Attachment #728392 - Flags: review?(nfroyd)
The diffs don't necessarily have a structure that mirrors the way I'm describing them.  But sometimes that's not a bad thing, as it's clear the code didn't change.
Attachment #728393 - Flags: review?(nfroyd)
Attachment #728394 - Flags: review?(nfroyd)
Attached patch Move IsPodSplinter Review
Attachment #728395 - Flags: review?(nfroyd)
Everything in the file's in order now, if you look at the final result of all these patches.  http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf is as close as you can get to the final C++11 spec to check against, as I understand it.  (It's only minor editorial changes away from the final thing, which isn't available unless $.)

I noticed this mini-simplification at some point, and while it's not relevant to this bug, it's easy enough to just post in passing here for review.
Attachment #728402 - Flags: review?(nfroyd)
Attachment #728390 - Flags: review?(nfroyd) → review+
Attachment #728392 - Flags: review?(nfroyd) → review+
Attachment #728393 - Flags: review?(nfroyd) → review+
Attachment #728394 - Flags: review?(nfroyd) → review+
Attachment #728395 - Flags: review?(nfroyd) → review+
Attachment #728402 - Flags: review?(nfroyd) → review+
Much thanks for splitting these up into individual pieces!
Comment on attachment 728390 [details] [diff] [review]
Add section references as comments

Review of attachment 728390 [details] [diff] [review]:
-----------------------------------------------------------------

One minor suggestion: attach the appropriate [meta.section.name] headers to the comments alongside of or in lieu of the numeric headings.
You need to log in before you can comment on or make changes to this bug.