Closed
Bug 853988
Opened 11 years ago
Closed 11 years ago
Organize TypeTraits.h the same way C++11 defines <type_traits>
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(6 files)
1.28 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
3.83 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.31 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.58 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
3.50 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.15 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Adding everything mishmashedly makes it harder to find things.
Assignee | ||
Comment 1•11 years ago
|
||
Having all these as one patch leads to a really messed-up diff. So this is going to be five or so patches -- first to add sectioning, then a bunch to move individual components into position. All trivial, no functionality change, just makes for easier diff-reading.
Attachment #728390 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #728392 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•11 years ago
|
||
The diffs don't necessarily have a structure that mirrors the way I'm describing them. But sometimes that's not a bad thing, as it's clear the code didn't change.
Attachment #728393 -
Flags: review?(nfroyd)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #728394 -
Flags: review?(nfroyd)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #728395 -
Flags: review?(nfroyd)
Assignee | ||
Comment 6•11 years ago
|
||
Everything in the file's in order now, if you look at the final result of all these patches. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf is as close as you can get to the final C++11 spec to check against, as I understand it. (It's only minor editorial changes away from the final thing, which isn't available unless $.) I noticed this mini-simplification at some point, and while it's not relevant to this bug, it's easy enough to just post in passing here for review.
Attachment #728402 -
Flags: review?(nfroyd)
Updated•11 years ago
|
Attachment #728390 -
Flags: review?(nfroyd) → review+
Updated•11 years ago
|
Attachment #728392 -
Flags: review?(nfroyd) → review+
Updated•11 years ago
|
Attachment #728393 -
Flags: review?(nfroyd) → review+
Updated•11 years ago
|
Attachment #728394 -
Flags: review?(nfroyd) → review+
Updated•11 years ago
|
Attachment #728395 -
Flags: review?(nfroyd) → review+
Updated•11 years ago
|
Attachment #728402 -
Flags: review?(nfroyd) → review+
Comment 7•11 years ago
|
||
Much thanks for splitting these up into individual pieces!
Comment 8•11 years ago
|
||
Comment on attachment 728390 [details] [diff] [review] Add section references as comments Review of attachment 728390 [details] [diff] [review]: ----------------------------------------------------------------- One minor suggestion: attach the appropriate [meta.section.name] headers to the comments alongside of or in lieu of the numeric headings.
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2af022787ee https://hg.mozilla.org/integration/mozilla-inbound/rev/9444636fb1d3 https://hg.mozilla.org/integration/mozilla-inbound/rev/6aaed09c846d https://hg.mozilla.org/integration/mozilla-inbound/rev/86d6a710f7fa https://hg.mozilla.org/integration/mozilla-inbound/rev/85dc97df0756 https://hg.mozilla.org/integration/mozilla-inbound/rev/14fd773be3cf https://hg.mozilla.org/integration/mozilla-inbound/rev/669d96cdd9ef I added them alongside of. I suppose those exist for better searchability, and/or for reference stability across added/removed sections, but if they don't show up in the PDF TOC, they're not quite a full replacement for the numbers. :-|
Target Milestone: --- → mozilla22
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f2af022787ee https://hg.mozilla.org/mozilla-central/rev/9444636fb1d3 https://hg.mozilla.org/mozilla-central/rev/6aaed09c846d https://hg.mozilla.org/mozilla-central/rev/86d6a710f7fa https://hg.mozilla.org/mozilla-central/rev/85dc97df0756 https://hg.mozilla.org/mozilla-central/rev/14fd773be3cf https://hg.mozilla.org/mozilla-central/rev/669d96cdd9ef
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•