Re-enable test_resize_move_windows.html on Linux

RESOLVED FIXED in mozilla22

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug)

Trunk
mozilla22
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 728641 [details] [diff] [review]
Patch

It was hardly broken locally so I took some time to fix what I was seeing. It seems to work fine now so I think we should give re-enabling a try.

I did two try runs:
https://tbpl.mozilla.org/?tree=Try&rev=25dde0a7eba7
https://tbpl.mozilla.org/?tree=Try&rev=4f97dcb62f9d

The first one has M-3 oranges that are fixed in the second one except the B2G ones which I fixed by disabling the test on B2G. Actually, the test can't run on B2G given that it consist of changing the size and the position of a window. That's not doable on our mobile implementations (Fx Android and Fx OS).
Attachment #728641 - Flags: review?(philringnalda)
(Assignee)

Updated

5 years ago
Attachment #728641 - Flags: review?(Ms2ger)
Comment on attachment 728641 [details] [diff] [review]
Patch

Haven't actually reviewed, but more test coverage is better, so rs=me.
Attachment #728641 - Flags: review?(philringnalda)
Attachment #728641 - Flags: review?(Ms2ger)
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
Target Milestone: --- → mozilla22
It did manage to pass a couple of times, which is nice, but when it doesn't, most of the time, it leaves the browser window shrunken down to the smallest possible size, which makes pretty much every test rather angry, and winds up taking two hours instead of twenty minutes.

Updated

5 years ago
Target Milestone: mozilla22 → ---
(Assignee)

Comment 6

5 years ago
Why has this been backed out? I do not see any reason given in the bug? Did tests failed? If yes, which tests? Can I have a log? Bug 677841 wasn't updated so I'm assuming no new occurrence of it happened.
(Assignee)

Comment 8

5 years ago
Thanks for the link. So it seems that one of the two tests was completely fine. I re-landed the patch by only re-enabling the non-chrome test. The issue I believe is that our old Fedora and the new Ubuntu systems don't use the same gtk versions so things can hardly work well in both (given that the tests seem to fail because gtk refuses to do some changes).

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e1bb7d0e21

Benjamin, sorry for yelling at you on IRC. However, I was really missing the information I needed to understand what happened.
No longer blocks: 834716
Summary: Re-enable test_resize_move_windows.html and test_resize_move_windows.xul on Linux → Re-enable test_resize_move_windows.html on Linux
Target Milestone: --- → mozilla22

Comment 9

5 years ago
You're right. My apologies for wasting your time.
Comment on attachment 728641 [details] [diff] [review]
Patch

Review of attachment 728641 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for fixing this.  Does this look good on try server?

::: dom/tests/mochitest/chrome/Makefile.in
@@ -74,5 @@
> -		$(NULL)
> -else
> -$(filter disabled-on-linux-for-timeouts--bug-834716, test_resize_move_windows.xul)
> -endif
> -

In general, I don't like this.  We are working towards moving into a manifest based solution for which tests run and don't run on a given platform or configuration.
Attachment #728641 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/a7e1bb7d0e21
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.