854121 - sources.xml is not regenerated unless I clobber out/

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When we build the image for a B2G device, we include a sources.xml file that shows what repositories and revisions the code used for that build came from.  This is important because it's generally good practice to be able to replicate builds of software.  This makes it possible to do things like bisect regressions.

However, the sources.xml file is only regenerated when:
 * the out/ directory is clobbered
 * the underlying manifest is updated
or similar situations.  In particular, it doesn't get updated when I just run:
  ./repo sync # this pulls new revisions for repositories tracked by branch
  ./build.sh
  ./flash.sh
which is a relatively common case.  Then I end up with a sources.xml that doesn't reflect the sources used to build what's on the phone; instead it reflects what last showed up when I clobbered out/.

This is relatively easy to fix; I'll make a pull request shortly.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Regenerate sources.xml unconditionally rather than only when the underlying manifest changes

Guessing a reviewer, possibly incorrectly.  Please redirect if needed.

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 728646 [details]
Regenerate sources.xml unconditionally rather than only when the underlying manifest changes

gonk-misc master: 7c22d3b

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

David, if you are using GECKO_PATH at all, this will still use the repo-managed copy of gecko for the manifests created.  We'd need to modify the add-revision.py script to be able to track the GECKO_PATH changes, as well as supporting native HG in that script for HG managed versions of Gecko.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Do you think it's worth uplifting this at all?

(I'm not using GECKO_PATH.)

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

https://github.com/mozilla-b2g/gonk-misc/commit/7c22d3bbb8732f5917c9642b5025717092ae2b89