"ASSERTION: This should not be called when mWindow is not null!" from document.open()

RESOLVED FIXED in mozilla23

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla23
All
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
A long time ago (in bug 659738), I made the version of document.open() that calls window.open() use nsDocument::GetWindowInternal() instead of JS_GetGlobalForObject. Turns out this asserts. Not sure what the expected API is here.
Just GetWindow(), I think.
(Assignee)

Updated

5 years ago
Assignee: nobody → Ms2ger
(Assignee)

Comment 2

5 years ago
Created attachment 731850 [details] [diff] [review]
Patch v1
Attachment #731850 - Flags: review?(bzbarsky)
Comment on attachment 731850 [details] [diff] [review]
Patch v1

r=me, but watch out for bustage from the MOZ_ASSERT bits...
Attachment #731850 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1e8c056926ce
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.