854324 - [Cardview] App title does not reflect language change.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[hanj.kim25]

Attachment: Steps to repro

1. Title : [Cardview] App title does not reflect language change.
2. Precondition : Go to Settings and ensure the language is set to English and notice the cardview displays app name in English.
3. Tester's Action : Go back to Settings and change language.
4. Detailed Symptom (ENG.) : Notice the cardview still displays the app name in English, not the newly changed language.
5. Expected : The app name in cardview should display in newly changed language.
6. Reproducibility: Y
   1)Frequency Rate : 100%
7.Build: AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.19.031, Mozilla build ID: 20130312070202

Comment 1

[Leo]

Hello all, 
I am going to use my own email address from now on.

Comment 2

[hanj.kim25]

(In reply to leo.bugzilla.gaia from comment #1)
> Hello all, 
I am going to use my own email address from now on.

Sigh.. I was using two different accounts with two different browser. I meant, I will be using '[e-mail]' from now.

Comment 3

[hanj.kim25]

Attachment: Pull request url

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 728880 [details]
Pull request url

Good catch.
r=me if you use SettingsListener instead of observer.

Comment 5

[hanj.kim25]

Comment on attachment 728880 [details]
Pull request url

I have changed it to use SettingsListener and squashed the commits into one. I'm requesting a review again. (Is this what you meant by r=me?)

Comment 6

[Evelyn Hung]

Comment on attachment 728880 [details]
Pull request url

(Alive is PTO now, I help on his review request) 
You've got his r+, it's okay to keep it, no need to request review again.
"r=me" means he help Tim on reviewing your patch.
Anyway, I'm going to merge your patch. Thanks for your nice work.

Comment 7

[Evelyn Hung]

Merged to Gaia master
https://github.com/mozilla-b2g/gaia/commit/552561d4805ca5ff66a987c7a2ee78022734dd31