doing "make purge" twice fails

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(b2g18 fixed, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
STR:
* make purge
* make purge

Expected:
* no error

Actual:
* we have an error :

  $ make purge
  adb shell stop b2g
  make: *** [purge] Erreur 1

This is especially problematic when doing |make reset-gaia| because |purge| is a dependency.
(Assignee)

Comment 1

5 years ago
Created attachment 728946 [details] [diff] [review]
patch v1

This inverts the check for the tmp directory so that it is true instead of
false.

Also removes the silent modifier for this line, there is no reason to silent
this line.
---
 Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Assignee: nobody → felash
Attachment #728946 - Flags: review?(fabrice)
Comment on attachment 728946 [details] [diff] [review]
patch v1

Review of attachment 728946 [details] [diff] [review]:
-----------------------------------------------------------------

::: Makefile
@@ +729,2 @@
>  	do \
> +		[ $$FILE = 'tmp' ] || $(ADB) shell rm -r $(MSYS_FIX)/data/local/$$FILE; \

That changes
Attachment #728946 - Flags: review?(fabrice) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Fabrice Desré [:fabrice] from comment #2)
> 
> Review of attachment 728946 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: Makefile
> @@ +729,2 @@
> >  	do \
> > +		[ $$FILE = 'tmp' ] || $(ADB) shell rm -r $(MSYS_FIX)/data/local/$$FILE; \
> 
> That changes

mmm yes ?
This is what you get when you start a review before 2 hours of triage and finish it after.
(Assignee)

Comment 5

5 years ago
master: 819e1621b5a8fb6175e4551e8ae14a5c2dd48629
v1-train: dcc5bc0c11de0f9633b9fc0bf48408d2791efdc7 (a=npotb)
v1.0.1: 4db5ee1208ae05dbc7c478109d90d5da6a345f41 (a=npotb)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g18: --- → fixed
status-b2g18-v1.0.1: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.