854446 - Make the destination file for drawing recording configurable

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Allow setting recording output file

We should have a pref that allows us to configure the destination file for a drawing recorder. The command-line recording tool also requires this.

Comment 1

[Bas Schouten (:bas.schouten)]

Comment on attachment 729011 [details] [diff] [review]
Allow setting recording output file

Review of attachment 729011 [details] [diff] [review]:
-----------------------------------------------------------------

Delegating review to Joe as Jeff is at GDC :)

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 729011 [details] [diff] [review]
Allow setting recording output file

Review of attachment 729011 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatform.cpp
@@ +388,5 @@
> +      } else {
> +        fileName.AssignLiteral("browserrecording.aer");
> +      }
> +
> +      gPlatform->mRecorder = Factory::CreateEventRecorderForFile(fileName.BeginReading());

Doesn't the operator const char*() work for this (instead of calling BeginReading() explicitly)?

Comment 3

[Bas Schouten (:bas.schouten)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22f4559c2f00

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/22f4559c2f00