Use in-XPI modules if a preference is set

RESOLVED FIXED in 1.14

Status

P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mossop, Unassigned)

Tracking

unspecified
1.14
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Currently bootstrap.js looks at the Firefox version to determine if it can use the modules built-in to Firefox. For 1.14 I'd like it to also check whether a specific preference is set.

This gives us an escape clause in the event that we determine that something is wrong with the modules in Firefox 21, we could either update Firefox 21 to set that pref (if not already released) or deploy a hotfix to set the pref for all users.
Give 'er
Priority: -- → P1
Target Milestone: --- → 1.14
(Reporter)

Comment 2

6 years ago
Created attachment 729096 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/890

Pointer to Github pull-request
(Reporter)

Updated

6 years ago
Attachment #729096 - Flags: review?(rFobic)
Attachment #729096 - Flags: review?(rFobic) → review+

Comment 3

6 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/78030fe8bb532448333c29f084f773981ee52d80
Bug 854465: Use in-XPI modules if a preference is set.

https://github.com/mozilla/addon-sdk/commit/3e818dd79a3b6637ff442e776da5d2d6e408bde4
Merge pull request #890 from Mossop/bug854465

Bug 854465: Use in-XPI modules if a preference is set. r=gozala
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 4

6 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f6a664597b15391b83a46d4a9121b6f17534b9e5
Merge pull request #890 from Mossop/bug854465

Bug 854465: Use in-XPI modules if a preference is set. r=gozala(cherry picked from commit 3e818dd79a3b6637ff442e776da5d2d6e408bde4)
You need to log in before you can comment on or make changes to this bug.