Closed Bug 85451 Opened 23 years ago Closed 23 years ago

M092, Trunk & N610 Crash while viewing certificate [@ nsTreeBoxObject::GetIndexOfItem]

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.3

People

(Reporter: greer, Assigned: javi)

References

(
URL
)

Details

(Keywords: crash, topcrash, Whiteboard: [br] fixed on branch)

Crash Data

Attachments

(5 files)

[patch] can't have overflow:auto on a tree
1.08 KB, patch
Details | Diff | Splinter Review
[patch] Slightly better patch
1.60 KB, patch
Details | Diff | Splinter Review
Patch which uses textbox instead of trees to display data.
1.74 KB, patch
Details | Diff | Splinter Review
Updated patch.
3.44 KB, patch
Details | Diff | Splinter Review
Patch with all comments incorporated.
3.59 KB, patch
Details | Diff | Splinter Review 
Talkback data form M091 shows multiple users crashing while viewing a site's 
certificate.

  (31479166) URL: www.excite.fr
     (31479166) Comments: I cheked the security info on a site. The crash arrive
when I checked the "Signature algorithme"
     (31476869) Comments: Trying to view the Subject's Public Key algorithm on
the Details page of the View Certificate.  The certificate is located at
http://www.engineerscard.com
     (31476630) Comments: Viewing the subject of a SSL certificate.  This
specific certificate can be found at http://www.engineerscard.com.  Click on the
link to login.  View the page info
     (31476187) Comments: I was viewing the properties of a SSL Certificate on a
secure site.
     (31467249) Comments: In certificate view
     (31466860) Comments: Clicked on something in certificate view


Stack Trace:
nsTreeBoxObject::GetIndexOfItem
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsTreeBoxObject.cpp  line 146]
         nsXULElement::RemoveChildAt
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line
2749]
         nsXULElement::RemoveChild
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line
1204]
         XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 139]
         XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line
1837]
         XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1242]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
809]
         js_Interpret   [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
2703]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
825]
         js_InternalInvoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  
line 897]
         JS_CallFunctionValue   [d:\builds\seamonkey\mozilla\js\src\jsapi.c  
line 3322]
         nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 937]
         nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 140]
         nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1120]
         nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1721]
         nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line
3631]
         nsOutlinerSelection::FireOnSelectHandler
[d:\builds\seamonkey\mozilla\layout\xul\base\src\outliner\src\nsOutlinerSelectio
n.cpp 
line 711]
         nsOutlinerSelection::Select
[d:\builds\seamonkey\mozilla\layout\xul\base\src\outliner\src\nsOutlinerSelectio
n.cpp 
line 355]
         XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 139]
         XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line
1837]
         XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1242]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
809]
         js_Interpret   [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
2703]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
825]
         js_InternalInvoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  
line 897]
         JS_CallFunctionValue   [d:\builds\seamonkey\mozilla\js\src\jsapi.c  
line 3322]
         nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 937]
         nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 140]
         nsXBLPrototypeHandler::ExecuteHandler
[d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLPrototypeHandler.cpp  line
430]
         DoMouse        
[d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLDragHandler.cpp 
line 99]
         nsXBLMouseHandler::MouseDown
[d:\builds\seamonkey\mozilla\content\xbl\src\nsXBLMouseHandler.cpp  line 108]
         nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1207]
         nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line
3631]
         PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 5519]
         PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 5441]
         nsView::HandleEvent    
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line
377]
         nsView::HandleEvent    
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line
350]
         nsView::HandleEvent    
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line
350]
         nsViewManager::DispatchEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp  line 2051]
         HandleEvent    [d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line 
68]
         nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 716]
         nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 733]
         nsWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 4197]
         ChildWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 4442]
         nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 3196]
         nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 980]
         USER32.DLL + 0x2e98 (0x77e02e98)
         USER32.DLL + 0x30e0 (0x77e030e0)
         USER32.DLL + 0x5824 (0x77e05824)
         nsWebShellWindow::ShowModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp  line 1085]
         nsContentTreeOwner::ShowAsModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsContentTreeOwner.cpp  line 393]
         nsWindowWatcher::OpenWindowJS
[d:\builds\seamonkey\mozilla\embedding\components\windowwatcher\src\nsWindowWatc
her.cpp 
line 701]
         nsWindowWatcher::OpenWindow
[d:\builds\seamonkey\mozilla\embedding\components\windowwatcher\src\nsWindowWatc
her.cpp 
line 438]
         nsNSSDialogHelper::openDialog
[d:\builds\seamonkey\mozilla\security\manager\pki\src\nsNSSDialogs.cpp  line 99]
         nsNSSDialogs::ViewCert
[d:\builds\seamonkey\mozilla\security\manager\pki\src\nsNSSDialogs.cpp  line
746]
         nsNSSCertificate::View
[d:\builds\seamonkey\mozilla\security\manager\ssl\src\nsNSSCertificate.cpp  line
1677]
         XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 139]
         XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line
1837]
         XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1242]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
809]
         js_Interpret   [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
2703]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
825]
         js_Interpret   [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
2703]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  li
Adding crash, topcrash keywords
Keywords: crash, topcrash
OS: other → Windows NT
->hyatt/0.9.2/critical/p1, cc evaughan
Assignee: trudelle → hyatt
Severity: normal → critical
Priority: -- → P1
Target Milestone: --- → mozilla0.9.2
Keywords: nsenterprise
--> jag

Spreading the crasher bug love around.
Assignee: hyatt → jaggernaut
I crashed once while trying to reproduce this bug from the EngineersCard log-in 
page (btw, clicking the link doesn't work, I have to c&p it from the source), 
but the call stack was completely different. I can't find how to get a secure 
page on www.excite.fr, and right now I can't get a secure connection to 
EngineersCard.

Can't reproduce this on the Fortify test page (http://www.fortify.net/ -> ssl 
check).

Any other pages I could try?
More specific steps?
I think the specific steps (judging by the fact that the call stack passing
from nsOutlinerSelection::FireOnSelectHandler into nsXULElement::RemoveChild 
and terminates in nsTreeBoxObject::GetIndexOfItem) is the one noted above
(but truncated): "Viewing the subject of a SSL certificate. This specific 
certificate can be found at http://www.engineerscard.com. Click on the
link to login. View the page info, security tab. View the Certificate. Click 
on the Details tab. Click on the subject." which implies clicking on an 
outliner item in one pane of the dialog, which triggers the rebuilding of 
the tree in the lower pane.

But, I just spent ~20minutes using the beta (win32, which is what all the 
crashes were on) with several different certificates in that dialog, clicking 
on all the items in the outliner, and did not crash.

But, a check of talkback shows that this crash continues to appear, and that
includes crashes in recent trunk builds.

Possible candidate for 'if (!treeFrame) return NS_OK;'?


This is the crash I got when I went to 
<https://secure01.bankhost.com/citibankusa/engineers/cgi-bin/cgi_chip?DE_USER_VA
LUE=140952&DE_WEB_PAGE_ID=entry&DE_WEB_COMMAND=Login>, opened the security 
window and clicked view. Eep! Now to find out who's messing up what :-)

memcpy(unsigned char * 0x00128fac, unsigned char * 0x00000000, unsigned long 12) 
line 297
nsNSSCertTrust::nsNSSCertTrust(CERTCertTrustStr * 0x00000000) line 200 + 18 
bytes
nsNSSCertificateDB::getCertType(CERTCertificateStr * 0x04326f48) line 3026
nsNSSCertificate::verifyFailed(unsigned int * 0x00129c28) line 979 + 12 bytes
nsNSSCertificate::GetUsageArray(char * 0x02dbaf1c, unsigned int * 0x00129c28, 
unsigned int * 0x00129a58, unsigned short * * 0x00129a60) line 1142
nsNSSCertificate::GetUsages(nsNSSCertificate * const 0x03f01cc8, unsigned int * 
0x00129c28, unsigned int * 0x00129c38, unsigned short * * * 0x00129c48) line 
1641 + 24 bytes
XPTC_InvokeByIndex(nsISupports * 0x03f01cc8, unsigned int 23, unsigned int 3, 
nsXPTCVariant * 0x00129c28) line 139
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode 
CALL_METHOD) line 1881 + 42 bytes
XPC_WN_CallMethod(JSContext * 0x0567a898, JSObject * 0x0568cd60, unsigned int 3, 
long * 0x056b7fac, long * 0x00129e5c) line 1252 + 11 bytes
js_Invoke(JSContext * 0x0567a898, unsigned int 3, unsigned int 0) line 807 + 23 
bytes
js_Interpret(JSContext * 0x0567a898, long * 0x0012ac00) line 2702 + 15 bytes
js_Invoke(JSContext * 0x0567a898, unsigned int 1, unsigned int 2) line 824 + 13 
bytes
js_InternalInvoke(JSContext * 0x0567a898, JSObject * 0x0568bcc0, long 90750576, 
unsigned int 0, unsigned int 1, long * 0x0012add8, long * 0x0012ad28) line 896 + 
20 bytes
JS_CallFunctionValue(JSContext * 0x0567a898, JSObject * 0x0568bcc0, long 
90750576, unsigned int 1, long * 0x0012add8, long * 0x0012ad28) line 3320 + 31 
bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x0567da48, void * 0x0568bcc0, 
void * 0x0568be70, unsigned int 1, void * 0x0012add8, int * 0x0012add4, int 0) 
line 941 + 33 bytes
nsJSEventListener::HandleEvent(nsJSEventListener * const 0x056b7690, nsIDOMEvent 
* 0x056bc774) line 139 + 57 bytes
nsEventListenerManager::HandleEventSubType(nsListenerStruct * 0x056a6f90, 
nsIDOMEvent * 0x056bc774, nsIDOMEventTarget * 0x0569da18, unsigned int 1, 
unsigned int 7) line 1161 + 20 bytes
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x0569b4f0, 
nsIPresContext * 0x056ab8e8, nsEvent * 0x0012b4e0, nsIDOMEvent * * 0x0012b498, 
nsIDOMEventTarget * 0x0569da18, unsigned int 7, nsEventStatus * 0x0012b508) line 
1834 + 36 bytes
GlobalWindowImpl::HandleDOMEvent(GlobalWindowImpl * const 0x0569da08, 
nsIPresContext * 0x056ab8e8, nsEvent * 0x0012b4e0, nsIDOMEvent * * 0x0012b498, 
unsigned int 1, nsEventStatus * 0x0012b508) line 602
DocumentViewerImpl::LoadComplete(DocumentViewerImpl * const 0x056af410, unsigned 
int 0) line 1119 + 47 bytes
nsDocShell::EndPageLoad(nsIWebProgress * 0x0567200c, nsIChannel * 0x056a6cc8, 
unsigned int 0) line 3671
nsWebShell::EndPageLoad(nsIWebProgress * 0x0567200c, nsIChannel * 0x056a6cc8, 
unsigned int 0) line 908
nsDocShell::OnStateChange(nsDocShell * const 0x05672b94, nsIWebProgress * 
0x0567200c, nsIRequest * 0x056a6cc8, int 131088, unsigned int 0) line 3592
nsDocLoaderImpl::FireOnStateChange(nsIWebProgress * 0x0567200c, nsIRequest * 
0x056a6cc8, int 131088, unsigned int 0) line 1095
nsDocLoaderImpl::doStopDocumentLoad(nsIRequest * 0x056a6cc8, unsigned int 0) 
line 734
nsDocLoaderImpl::DocLoaderIsEmpty() line 632
nsDocLoaderImpl::OnStopRequest(nsDocLoaderImpl * const 0x05671ffc, nsIRequest * 
0x05732aa8, nsISupports * 0x056ab8e8, unsigned int 0) line 563
nsLoadGroup::RemoveRequest(nsLoadGroup * const 0x05693ce0, nsIRequest * 
0x05732aa8, nsISupports * 0x056ab8e8, unsigned int 0) line 512 + 44 bytes
imgRequestProxy::OnStopRequest(imgRequestProxy * const 0x05732ab0, nsIRequest * 
0x05734bf0, nsISupports * 0x00000000, unsigned int 0) line 387
imgRequest::OnStopRequest(imgRequest * const 0x05732a18, nsIRequest * 
0x05734bf0, nsISupports * 0x00000000, unsigned int 0) line 637
ProxyListener::OnStopRequest(ProxyListener * const 0x05734998, nsIRequest * 
0x05734bf0, nsISupports * 0x00000000, unsigned int 0) line 376
nsJARChannel::OnStopRequest(nsJARChannel * const 0x05734bf4, nsIRequest * 
0x0569ed04, nsISupports * 0x00000000, unsigned int 0) line 584 + 49 bytes
nsOnStopRequestEvent::HandleEvent() line 161
nsARequestObserverEvent::HandlePLEvent(PLEvent * 0x0569c99c) line 64
PL_HandleEvent(PLEvent * 0x0569c99c) line 590 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x05681a28) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x002b0322, unsigned int 49469, unsigned int 0, 
long 90708520) line 1071 + 9 bytes
USER32! 77e12e98()
USER32! 77e130e0()
USER32! 77e15824()
nsXULWindow::ShowModal(nsXULWindow * const 0x05681858) line 275
nsWebShellWindow::ShowModal(nsWebShellWindow * const 0x05681858) line 1085
nsContentTreeOwner::ShowAsModal(nsContentTreeOwner * const 0x0569f47c) line 393
nsWindowWatcher::OpenWindowJS(nsWindowWatcher * const 0x010eadcc, nsIDOMWindow * 
0x00000000, const char * 0x051fdbe8, const char * 0x051fd468, const char * 
0x051fd414, int 1, unsigned int 1, long * 0x05693e88, nsIDOMWindow * * 
0x0012c53c) line 700
nsWindowWatcher::OpenWindow(nsWindowWatcher * const 0x010eadc8, nsIDOMWindow * 
0x00000000, const char * 0x051fdbe8, const char * 0x051fd468, const char * 
0x051fd414, nsISupports * 0x05676078, nsIDOMWindow * * 0x0012c53c) line 436 + 48 
bytes
nsNSSDialogHelper::openDialog(nsIDOMWindowInternal * 0x00000000, const char * 
0x051fdbe8, nsISupports * 0x05676078) line 98 + 71 bytes
nsNSSDialogs::ViewCert(nsNSSDialogs * const 0x04337608, nsIX509Cert * 
0x03f01cc8) line 745 + 21 bytes
nsNSSCertificate::View(nsNSSCertificate * const 0x03f01cc8) line 1686 + 27 bytes
XPTC_InvokeByIndex(nsISupports * 0x03f01cc8, unsigned int 25, unsigned int 0, 
nsXPTCVariant * 0x0012c730) line 139
XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode 
CALL_METHOD) line 1881 + 42 bytes
XPC_WN_CallMethod(JSContext * 0x04418de0, JSObject * 0x042b85d0, unsigned int 0, 
long * 0x056a4468, long * 0x0012c964) line 1252 + 11 bytes
js_Invoke(JSContext * 0x04418de0, unsigned int 0, unsigned int 0) line 807 + 23 
bytes
js_Interpret(JSContext * 0x04418de0, long * 0x0012d708) line 2702 + 15 bytes
js_Invoke(JSContext * 0x04418de0, unsigned int 0, unsigned int 0) line 824 + 13 
bytes
js_Interpret(JSContext * 0x04418de0, long * 0x0012e464) line 2702 + 15 bytes
js_Invoke(JSContext * 0x04418de0, unsigned int 1, unsigned int 2) line 824 + 13 
bytes
js_InternalInvoke(JSContext * 0x04418de0, JSObject * 0x042b75b8, long 69961648, 
unsigned int 0, unsigned int 1, long * 0x0012e63c, long * 0x0012e58c) line 896 + 
20 bytes
JS_CallFunctionValue(JSContext * 0x04418de0, JSObject * 0x042b75b8, long 
69961648, unsigned int 1, long * 0x0012e63c, long * 0x0012e58c) line 3320 + 31 
bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x04322be8, void * 0x042b75b8, 
void * 0x042b87b0, unsigned int 1, void * 0x0012e63c, int * 0x0012e638, int 0) 
line 941 + 33 bytes
nsJSEventListener::HandleEvent(nsJSEventListener * const 0x04456d58, nsIDOMEvent 
* 0x0567d384) line 139 + 57 bytes
nsEventListenerManager::HandleEventSubType(nsListenerStruct * 0x0439e780, 
nsIDOMEvent * 0x0567d384, nsIDOMEventTarget * 0x0439e650, unsigned int 8, 
unsigned int 7) line 1161 + 20 bytes
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x04456cf0, 
nsIPresContext * 0x03fface0, nsEvent * 0x0012f144, nsIDOMEvent * * 0x0012f008, 
nsIDOMEventTarget * 0x0439e650, unsigned int 7, nsEventStatus * 0x0012f18c) line 
2131 + 36 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x0439e648, nsIPresContext * 
0x03fface0, nsEvent * 0x0012f144, nsIDOMEvent * * 0x0012f008, unsigned int 1, 
nsEventStatus * 0x0012f18c) line 3635
PresShell::HandleDOMEventWithTarget(PresShell * const 0x04066ab8, nsIContent * 
0x0439e648, nsEvent * 0x0012f144, nsEventStatus * 0x0012f18c) line 5613 + 39 
bytes
nsButtonBoxFrame::MouseClicked(nsIPresContext * 0x03fface0, nsGUIEvent * 
0x0012f340) line 181
nsButtonBoxFrame::HandleEvent(nsButtonBoxFrame * const 0x0449cb80, 
nsIPresContext * 0x03fface0, nsGUIEvent * 0x0012f340, nsEventStatus * 
0x0012f64c) line 128
PresShell::HandleEventInternal(nsEvent * 0x0012f340, nsIView * 0x00000000, 
unsigned int 1, nsEventStatus * 0x0012f64c) line 5581 + 41 bytes
PresShell::HandleEventWithTarget(PresShell * const 0x04066ab8, nsEvent * 
0x0012f340, nsIFrame * 0x0449cb80, nsIContent * 0x0439e648, unsigned int 1, 
nsEventStatus * 0x0012f64c) line 5539 + 22 bytes
nsEventStateManager::CheckForAndDispatchClick(nsEventStateManager * const 
0x04411990, nsIPresContext * 0x03fface0, nsMouseEvent * 0x0012f758, 
nsEventStatus * 0x0012f64c) line 2455 + 61 bytes
nsEventStateManager::PostHandleEvent(nsEventStateManager * const 0x04411998, 
nsIPresContext * 0x03fface0, nsEvent * 0x0012f758, nsIFrame * 0x0449cb80, 
nsEventStatus * 0x0012f64c, nsIView * 0x04498e00) line 1540 + 28 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f758, nsIView * 0x04498e00, 
unsigned int 1, nsEventStatus * 0x0012f64c) line 5586 + 43 bytes
PresShell::HandleEvent(PresShell * const 0x04066abc, nsIView * 0x04498e00, 
nsGUIEvent * 0x0012f758, nsEventStatus * 0x0012f64c, int 1, int & 1) line 5493 + 
25 bytes
nsView::HandleEvent(nsView * const 0x04498e00, nsGUIEvent * 0x0012f758, unsigned 
int 28, nsEventStatus * 0x0012f64c, int 1, int & 1) line 377
nsViewManager::DispatchEvent(nsViewManager * const 0x042687c0, nsGUIEvent * 
0x0012f758, nsEventStatus * 0x0012f64c) line 2051
HandleEvent(nsGUIEvent * 0x0012f758) line 68
nsWindow::DispatchEvent(nsWindow * const 0x04499b4c, nsGUIEvent * 0x0012f758, 
nsEventStatus & nsEventStatus_eIgnore) line 720 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f758) line 741
nsWindow::DispatchMouseEvent(unsigned int 301, nsPoint * 0x00000000) line 4237 + 
21 bytes
ChildWindow::DispatchMouseEvent(unsigned int 301, nsPoint * 0x00000000) line 
4486
nsWindow::ProcessMessage(unsigned int 514, unsigned int 0, long 10879025, long * 
0x0012fb9c) line 3203 + 24 bytes
nsWindow::WindowProc(HWND__ * 0x00ba03c4, unsigned int 514, unsigned int 0, long 
10879025) line 988 + 27 bytes
USER32! 77e12e98()
USER32! 77e130e0()
USER32! 77e15824()
nsAppShellService::Run(nsAppShellService * const 0x010f28e0) line 419
main1(int 1, char * * 0x00357748, nsISupports * 0x00000000) line 1161 + 32 bytes
main(int 1, char * * 0x00357748) line 1464 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e97d08()

Er, totally different bug from this one, no?
Yes indeed. But since it's also preventing me to reproduce this bug, I figured 
it was worth mentioning.
And yeah, I could just bullet proof treeFrame, but I'd rather find out what's 
really going on here. As a 0.9.2 "fix", I think it might suffice, but I'll need 
a computer on which I can reproduce this crash to test it on (or perhaps just 
better steps / more sites)
Keywords: nsBranch
Target Milestone: mozilla0.9.2 → mozilla0.9.3
your nsNSSCertificate crash is bug 87675, for which a fix was checked into 
the branch today (I don't know why not on the trunk, though).
I can now view the security info, click on any of the items and not crash.
This apparently was also a major crasher for AIM, with the same root cause. A 
<tree> doesn't need overflow:auto, so just remove 'em.
sr=hyatt

r=hixie
Status: NEW → ASSIGNED
Keywords: patch
Whiteboard: has r=,sr=, needs a=
This patch actually needs some tweaking. As is, the middle pane will collapse 
to two rows and the third pane will resize itself freely, resulting in the 
cancel and ok button being hidden at times.

Slightly better patch coming up.
javi: I'd rather not try and second-guess what you guys wanted with this dialog,
'coz I'm bound to be wrong.

So, given the constraint that you can't use style="overflow:auto" to give those
two trees a fixed size and have a scrollbar (it will make the tree element have
a scrollview frame instead of a tree frame and mess up a lot of tree code), and
taking into account the sample "fix" I appended, can you come up with something
that sucks less than my patch and does what you want?
Assignee: jaggernaut → javi
Status: ASSIGNED → NEW
Whiteboard: has r=,sr=, needs a=
This is still a bug in 2001062608. Just ran into it trying to view the
certificate of http://www.oods.org/

I'm running Debian Potato on x86, using nightly builds.

javi, can you come up with a better patch per jag?

If not, I think we should take one of the patches on the branch.  A somewhat
misshapen (or too small) dialog is better than a topcrash.
Whiteboard: [br]
Summary: M091 Crash while viewing certificate [@ nsTreeBoxObject::GetIndexOfItem] → M092, Trunk & N610 Crash while viewing certificate [@ nsTreeBoxObject::GetIndexOfItem]
Updating summary with M092, Trunk and N610 since this is still occurring with
Mozilla 0.9.2, MozillaTrunk and N610 branch builds.
sr=blake on the branch workaround
OS: Windows NT → All
Hardware: PC → All
r=bbaetz for the branch. Yuck :)
PDT+ per e-mail. Gotta get this in tonight.
Whiteboard: [br] → [PDT+][br]
landed patch on branch
Keywords: vbranch
Whiteboard: [PDT+][br] → [br]
Whiteboard: [br] → [PDT+][br]
update whiteboard - Thanks for the fix on the branch!
Whiteboard: [PDT+][br] → [PDT+][br] fixed on branch
This looks like a dup of 90962 (which has a proposed fix in hand)
This work around is no good IMHO.

This will break displaying the certificate for "Thawte Universal CA Root"

View the cert and select "Certificate Signature Value" and the Close and Help
buttons will disappear.

The patch attached to 60692 fixes this without breaking the display of the
"Thawte Universal CA Root" certificate.
It looks to me like that fix just works around what jag pointed out:

> So, given the constraint that you can't use style="overflow:auto" to give those
> two trees a fixed size and have a scrollbar (it will make the tree element have
> a scrollview frame instead of a tree frame and mess up a lot of tree code)

In other words, that trying the QI the frame to an nsITreeFrame will fail
because you have a scrollview frame...
Whiteboard: [PDT+][br] fixed on branch → [br] fixed on branch
I mis-read the patch.  I just looked at the latest build and the certificate in
question displays correctly.  So this patch is fine.
Note however that this isn't the correct fix for the trunk (the fixed height
style shouldn't be used), hence my request of you earlier to fix this better in
a better way. Perhaps the best solution here would be to wait for bug 88138 to
be fixed and just put the rows attributes on those trees.
*** Bug 90962 has been marked as a duplicate of this bug. ***
What is wrong with checking in the patch that went into the branch onto the trunk?

r=ddrinan.
sr=blizzard
http://lxr.mozilla.org/mozilla/search?string=certDumpVal

You're calling removeChildrenInTree(certDumpVal) twice, but you've only fixed
one case. Once you've removed both cases it looks like you can remove the helper
function.

You also don't need to certDumpVal.setAttribute("multiline", "true")
from your js, it won't change.

Instead of a fixed height it looks like you can also use the rows attribute:

http://lxr.mozilla.org/seamonkey/search?string=multiline%3D%22true%22
>You also don't need to certDumpVal.setAttribute("multiline", "true")
>from your js, it won't change.

That was necessary because scrollbars wouldn't show up after updating the
content of the bottom panel.


Using style= "height:100px" to set height.

Updated patch coming.
Attached patch Updated patch. — — Splinter Review 

    
    

    
  
Why not:

<textbox multiline="true" rows="10"/>

? The fixed height will mess you up for fonts which are slightly taller/shorter.

The scrollbars not showing is another bug (I think). Could you add a comment
like:

certDumpVal.setAttribute("multiline", "true"); //XXXjavi To show scrollbars, see
bug X

You can file a new bug for that and keep this work-around in. There might
already be a bug on it, you might want to check bugzilla first.

cc'ing blake and Ben, they might know more about this.

    
    

    
  
I took the line out and scroll bars show up now.  There must've been something
with my original patch that was causing scroll bars to not work.

In summary, my latest patch without the line:
  certDumpVal.setAttribute("multiline", "true");

works as expected.

    
    

    
  
+    <treecols>

<treecols> is deprecated, use <treecolgroup>, other than that this looks good.

    
    

    
  
Patch checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Marking this verified fixed.  Talkback data only shows 2 incidents with Netscape
6.20.  If anyone is curious to find out more about them, the incidents are:  
37746389 and 37746279 .
Status: RESOLVED → VERIFIED

    
  
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Crash Signature: [@ nsTreeBoxObject::GetIndexOfItem]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: