854545 - mach Exception: Binary expected at objdir-android/dist/bin/fennec does not exist

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Peterson [:cpeterson]]

I get the following mach error when I make a clobber build of Firefox for Android from mozilla-central:


Exception: Binary expected at /Users/cpeterson/Code/mozilla/central/objdir-android/dist/bin/fennec does not exist.

  File "/Users/cpeterson/Code/mozilla/central/python/mozbuild/mozbuild/mach_commands.py", line 131, in build
    app_path = self.get_binary_path('app')
  File "/Users/cpeterson/Code/mozilla/central/python/mozbuild/mozbuild/base.py", line 159, in get_binary_path
    raise Exception('Binary expected at %s does not exist.' % path)

Comment 1

[Gregory Szorc [:gps]]

I know very little about the Android developer workflow. Is there an expected output of |mach build| for mobile/android that is executable? I /think/ the answer is "no" and that |mach package| is required to obtain anything useful for Android. If so, my first reaction is that we should expose a single command that does useful things. My second is that we could not check for a binary if the xul app is mobile/android.

Comment 2

[Richard Newman [:rnewman]]

There is no desktop-runnable output binary for Fennec. If there were, it probably wouldn't be called `fennec`!

The usual useful output is the APK, which is created by packaging.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Don't print binary info for mobile/android builds, v1

I think this should do it.

Comment 4

[Gregory Szorc [:gps]]

Pretend I uploaded that patch with self.substs['MOZ_BUILD_APP'] not MOZ_APP_NAME...

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 729941 [details] [diff] [review]
Don't print binary info for mobile/android builds, v1

Review of attachment 729941 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with your noted fix

Comment 6

[Nick Alexander :nalexander [he/him]]

This is a fine work-around.  See Bug 854534 for tracking folding some of `make package` into `make libs`.  If we pursue that ticket, we could point the user at an APK.

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c7f9d160488

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c7f9d160488