854600 - PermissionSettings' init method should return a non-XPCOM object

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Guilherme Gonçalves [:ggp]]

The object returned from init() in an implementation of nsIDOMGlobalPropertyInitializer should be a different object implementing only the API to be exposed, and nothing more.

If the XPCOM object itself is returned -- and note that returning nothing from init() also causes the XPCOM object to be used --  it is possible to QI into that object and, for example, call init() again, which might not be safe.

Comment 1

[Reuben Morais [:reuben]]

Attachment: Move PermissionSettings to WebIDL

Comment 2

[Reuben Morais [:reuben]]

Depends on bug 971766 for the pref to ignore app type checks.

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 8382600 [details] [diff] [review]
Move PermissionSettings to WebIDL

Review of attachment 8382600 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/permission/PermissionPromptService.js
@@ -28,5 @@
>  
> -XPCOMUtils.defineLazyServiceGetter(this,
> -                                   "PermSettings",
> -                                   "@mozilla.org/permissionSettings;1",
> -                                   "nsIDOMPermissionSettings");

Also remove from http://mxr.mozilla.org/mozilla-central/source/b2g/components/ContentPermissionPrompt.js#38

Comment 4

[Gregor Wagner [:gwagner]]

Don't forget to fix and land.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Reuben, are you ready to land this?

Comment 6

[Reuben Morais [:reuben]]

I need to address the review comments in bug 971766, land it, and then I can land this.

Comment 7

[Reuben Morais [:reuben]]

And to address those review comments, I need bug 952486. Michael, I think you should go ahead and change the XPIDL if you need to land a change to PermissionSettings soon.

Comment 8

[Reuben Morais [:reuben]]

Fixed by bug 985796.